Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune footer styling #3007

Closed
mmmavis opened this issue Apr 11, 2019 · 4 comments · Fixed by #3026
Closed

Fine tune footer styling #3007

mmmavis opened this issue Apr 11, 2019 · 4 comments · Fixed by #3026

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 11, 2019

Follow-up for PR #2998

To make sure things match what we have on the mockups.

  • hover state
  • form error state for form related stuff we'll revisit when form standardization work is done.
@mmmavis mmmavis changed the title fine tune footer styling Fine tune footer styling Apr 11, 2019
@kristinashu
Copy link

kristinashu commented Apr 11, 2019

Please have @natalieworth and @sabrinang review the PR when it's ready!

@mmmavis mmmavis self-assigned this Apr 16, 2019
@mmmavis mmmavis removed the blocked label Apr 16, 2019
@sabrinang
Copy link

@mmmavis for the "Mozilla is a global non-profit ..." text please change this to .body-small.
For dark theme .body-small links and other paragraph links, let's change the links to be in $light-blue.

@kristinashu
Copy link

kristinashu commented Apr 18, 2019

@mmmavis can I add one more update to this ticket (if not I can open a separate one). Please update the two mozilla.org links (logo & "Visit us at mozilla.org") to go to foundation.mozilla.org instead and say "Visit us at foundation.mozilla.org". Abigail from legal says if we're talking about the not for profit then we shouldn't be linking to moz.org.

image

@mmmavis
Copy link
Collaborator Author

mmmavis commented Apr 18, 2019

@kristinashu sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants