Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localise the primarypage intro field #2954

Merged
merged 5 commits into from
Apr 9, 2019
Merged

localise the primarypage intro field #2954

merged 5 commits into from
Apr 9, 2019

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Apr 3, 2019

Closes #2941

image

@Pomax Pomax requested review from alanmoo and youriwims April 3, 2019 16:04
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2954 April 3, 2019 16:04 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2954 April 3, 2019 16:05 Inactive
youriwims
youriwims approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@youriwims youriwims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-2954 April 5, 2019 15:20 Inactive
alanmoo
alanmoo previously requested changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@alanmoo alanmoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but needs a migration update. Once you do that, dismiss this and merge away.

@TheoChevalier
Copy link
Contributor

Thanks for fixing this! Any estimate as to when this could hit production?

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-2954 April 9, 2019 14:34 Inactive
@youriwims youriwims dismissed alanmoo’s stale review April 9, 2019 14:47

updated migration file

@youriwims
Copy link
Contributor

PrimaryPage localization can be viewed and tested here.

@youriwims youriwims merged commit c7d9f04 into master Apr 9, 2019
@youriwims youriwims deleted the localize-intro-pp branch April 9, 2019 14:49
Pomax added a commit that referenced this pull request Apr 9, 2019
@Pomax
Revert "localise the primarypage intro field (#2954)"
57e802e 
This reverts commit c7d9f04.
This was referenced Apr 9, 2019
Merged
Merged
Pomax added a commit that referenced this pull request Apr 9, 2019
@Pomax
Revert "localise the primarypage intro field (#2954)" (#2985)
ac235e3 
This reverts commit c7d9f04.
@Pomax
Copy link
Contributor Author

Pomax commented Apr 9, 2019

continued in #2986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youriwims youriwims youriwims approved these changes

@alanmoo alanmoo alanmoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pomax @TheoChevalier @youriwims @alanmoo @cadecairos