Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable localization of "Intro" field on BanneredCampaignPages #2941

Closed
alanmoo opened this issue Apr 2, 2019 · 3 comments · Fixed by #2986
Closed

Enable localization of "Intro" field on BanneredCampaignPages #2941

alanmoo opened this issue Apr 2, 2019 · 3 comments · Fixed by #2986
Assignees
@Pomax
Labels
backend

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Apr 2, 2019

Describe the bug
The field labeled "Intro" on BanneredCampaignPage can't be localized. Let's make that possible.
image
@alanmoo alanmoo added the backend label Apr 2, 2019
@Pomax Pomax self-assigned this Apr 2, 2019
@Pomax
Copy link
Contributor

Pomax commented Apr 2, 2019

This is an inherited field from PrimaryPage, so we'd have to enable it for all primary pages. If that's fine then this should be a quick thing to do.

@alanmoo
Copy link
Contributor Author

alanmoo commented Apr 3, 2019

Yeah, that's good.

@Pomax Pomax mentioned this issue Apr 3, 2019
Merged
@Pomax Pomax mentioned this issue Apr 9, 2019
Merged
@Pomax
Copy link
Contributor

Pomax commented Apr 9, 2019

accidentally landed the wrong code.

@Pomax Pomax reopened this Apr 9, 2019
@Pomax Pomax mentioned this issue Apr 9, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Jul 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pomax Pomax

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

localise the primarypage intro field MozillaFoundation/foundation.mozilla.org
2 participants
@Pomax @alanmoo