Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Martial arts tweaks and fixes #5114

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Jan 26, 2025

About The Pull Request

This makes a few changes/tweaks to martial arts stuff, alongside fixing a few bugs. I feel like it's explained particularly well enough in the changelog, so I won't repeat the same thing.

Why It's Good For The Game

I feel like these changes just kinda make martial arts stuff more smooth overall, and a bugfix or so in the process is a nice bonus.

Changelog

🆑
fix: Awakened Dragon's attacks now do the intended amount of damage.
fix: Awakened Dragon and Tunnel Arts now have fully consistent counter/dodge effects with the blood cult stun hand.
fix: When a touch attack gets dodged by a martial arts user, the attacker will properly have their click cooldown set.
balance: Sleeping Carp, Awakened Dragon, and Tunnel Arts will now dodge/counter touch attacks regardless of combat mode if they're considered a "dangerous" attack (pretty much everything except genetics shock touch)
balance: Tunnel Arts' illusionary warriors now move at the same speed as normal humans, rather than the typical slower rate than most simplemobs do.
qol: Categorized many martial arts-related chat messages as being combat-related in chat tabs.
/:cl:

@Absolucy Absolucy added Fix fix da bug Balance perfectly balanced as all things should be QoL improves quality of life labels Jan 26, 2025
@TheLobsterrr
Copy link

i dunno about giving acarp stamina damage on keelhaul, i know it was intended to do so but it will make it practically nigh unstoppable with how fast itll be able to stamcrit and sleep people if you know how to press right click three times

@Absolucy Absolucy added the awaiting admin review PR is fine code-wise, just needs admin approval now. label Jan 27, 2025
Copy link
Collaborator

@F-e-r-n F-e-r-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TM first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting admin review PR is fine code-wise, just needs admin approval now. Balance perfectly balanced as all things should be Fix fix da bug QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants