Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - Fixes Heart Worms being able to round remove the entire crew. #3994

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

Yawet330
Copy link
Contributor

@Yawet330 Yawet330 commented Oct 27, 2024

About The Pull Request

Fixes Heart Worms permakilling people on penthrite and with vein muscles.

Why was this even a thing? Just calling mob.death() instead of doing progressive damage, or anything else. This was lazy code that round removed so many people on RID 7547.

For reference; (this is an edit) the code itself gives you penthrite as a "last ditch warning to get defibbed", thus the symptom almost always caused this issue by itself.

You are just cooked at the moment; there is no alternative other than death.

Why It's Good For The Game

what the fuck?

Fixes a critical bug that allowed you to round remove people as botany with extreme ease and very little ways to fix it. If you broke the Cloner and broke the ore silo and research servers (no way to make new cloners); you could essentially, kill the entire crew in 1-2 840u melons with gaseous decomposition.

Or as chemist with the rapid chemical syringe gun (traitor item).

This was an extremely low effort way to grief, and an even more low effort way to accidentally grief.

fixes a critical bug

Changelog

🆑
fix: Heart Worms now respects penthrite and vein muscle threading. Like it was supposed to (indicated by its own code)
fix: Heart Worms now no longer instantly kills you if you have CE_STABLEHEART or for some reason are immune to heart attacks WITH stableheart.
/:cl:

@Yawet330 Yawet330 changed the title what the fuck [FIX] - Fixes Heart Worms being able to round remove the entire crew. Oct 27, 2024
@dwasint dwasint merged commit 1225289 into Monkestation:master Oct 28, 2024
26 checks passed
github-actions bot added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants