Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed Flex notice on report #1967

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat: removed Flex notice on report #1967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae4b178
removed Flex notice on report
qcdyx Feb 4, 2025
ea58bf4
Merge branch 'master' into 1961-remove-flex-alert-from-httpsgithubcom…
qcdyx Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeatureMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ public String getFeatureName() {
return featureName;
}

public String getFeatureGroup() {
return featureGroup;
}

public String getDocUrl() {
String formattedFeatureName = featureName.toLowerCase().replace(' ', '-');
String formattedFeatureGroup = featureGroup.toLowerCase().replace(' ', '_');
Expand Down
10 changes: 0 additions & 10 deletions main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,14 +618,4 @@ public void setFilenames(ImmutableSortedSet<String> filenames) {
public ImmutableSortedSet<String> getFilenames() {
return filenames;
}

public Boolean hasFlexFeatures() {
return specFeatures.keySet().stream()
.anyMatch(
feature ->
feature.getFeatureGroup() != null
&& feature.getFeatureGroup().equals("Flexible Services")
&& !Objects.equals(feature.getFeatureName(), "Continuous Stops")
&& specFeatures.get(feature));
}
}
15 changes: 0 additions & 15 deletions main/src/main/resources/report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,6 @@
align-content: center;
flex-wrap: wrap;
}

.warning-display {
padding: 10px;
border: solid 2px orange;
border-radius: 11px;
width: fit-content;
font-weight: bold;
}
</style>

</head>
Expand All @@ -247,13 +239,6 @@ <h1>GTFS Schedule Validation Report</h1>

<p>Use this report alongside our <a href="https://gtfs-validator.mobilitydata.org/rules.html">documentation</a>.</p>

<div th:if="${metadata}">
<p class="warning-display" th:if="${metadata.hasFlexFeatures}">
&#9888; This feed contains GTFS Flex features. Please note that GTFS Flex validation support is still in development.
You can manually review all the validation rules for Flex data <a href="https://docs.google.com/document/d/1QABoIeOdR6lAB7A6_X6WIbZwC7EnAIZvm_hRNwNQeoI/edit#heading=h.mky28yjwt08z">here</a>.
</p>
</div>

<p class="version-update" th:if="${summary.newVersionOfValidatorAvailable}">A new version of the <a
href="https://github.com/MobilityData/gtfs-validator/releases">Canonical GTFS Schedule validator</a> is available!
Please update to get the latest/best validation results.</p>
Expand Down
Loading