Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed Flex notice on report #1967

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Feb 4, 2025

Summary:
Closes #1961

Expected behavior:
Before:
image
After:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@emmambd
Copy link
Contributor

emmambd commented Feb 4, 2025

LGTM on a QA side!

Copy link
Contributor

github-actions bot commented Feb 4, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit e4b244b
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1801 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.67 3.78 ⬆️+0.12
Median -- 1.36 1.44 ⬆️+0.09
Standard Deviation -- 10.33 10.42 ⬆️+0.09
Minimum in References Reports us-california-flex-v2-developer-test-feed-2-gtfs-1818 0.48 0.61 ⬆️+0.12
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 272.26 274.58 ⬆️+2.33
Minimum in Latest Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 0.61 0.50 ⬇️-0.12
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 272.26 274.58 ⬆️+2.33
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 465.83 MiB 464.55 MiB ⬇️-1.29 MiB
Median -- 331.92 MiB 331.92 MiB ⬇️0 bytes
Standard Deviation -- 771.29 MiB 765.25 MiB ⬇️-6.04 MiB
Minimum in References Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 38.25 MiB 68.37 MiB ⬆️+30.11 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.86 GiB 10.94 GiB ⬆️+90.79 MiB
Minimum in Latest Reports us-colorado-via-mobility-gtfs-180 399.92 MiB 39.17 MiB ⬇️-360.75 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.86 GiB 10.94 GiB ⬆️+90.79 MiB

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qcdyx qcdyx merged commit 183bcfd into master Feb 4, 2025
132 checks passed
@qcdyx qcdyx deleted the 1961-remove-flex-alert-from-httpsgithubcommobilitydatagtfs-validatorissues1778 branch February 4, 2025 22:14
Copy link
Contributor

github-actions bot commented Feb 4, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit aa8d1ad
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1801 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1801 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.64 3.72 ⬆️+0.08
Median -- 1.33 1.38 ⬆️+0.05
Standard Deviation -- 10.39 10.51 ⬆️+0.11
Minimum in References Reports us-california-catalina-express-gtfs-299 0.47 0.54 ⬆️+0.07
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 274.11 279.45 ⬆️+5.34
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.47 0.49 ⬆️+0.02
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 274.11 279.45 ⬆️+5.34
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 465.02 MiB 476.76 MiB ⬆️+11.74 MiB
Median -- 333.40 MiB 331.92 MiB ⬇️-1.48 MiB
Standard Deviation -- 770.45 MiB 842.06 MiB ⬆️+71.60 MiB
Minimum in References Reports us-florida-bay-town-trolley-gtfs-337 38.57 MiB 399.92 MiB ⬆️+361.35 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.57 GiB 10.86 GiB ⬆️+299.74 MiB
Minimum in Latest Reports us-california-thousand-oaks-transit-gtfs-33 42.86 MiB 39.24 MiB ⬇️-3.62 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.57 GiB 10.86 GiB ⬆️+299.74 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Flex alert from https://github.com/MobilityData/gtfs-validator/issues/1778
3 participants