Add Write + Conflict Resolution #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mramotar <mramotar@dropbox.com>
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
Signed-off-by: mramotar <mramotar@dropbox.com>
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/Fetcher.kt
Outdated
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/ItemValidator.kt
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/ItemValidator.kt
Outdated
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/MutableStore.kt
Outdated
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/MutableStore.kt
Outdated
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreBuilder.kt
Outdated
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreBuilder.kt
Outdated
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreWriteRequest.kt
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/FetcherController.kt
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStore.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: mramotar <mramotar@dropbox.com>
Signed-off-by: mramotar <mramotar@dropbox.com>
matt-ramotar
commented
Dec 21, 2022
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/Read.kt
Show resolved
Hide resolved
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealMutableStore.kt
Outdated
Show resolved
Hide resolved
digitalbuddha
previously approved these changes
Dec 21, 2022
Signed-off-by: mramotar <mramotar@dropbox.com>
Signed-off-by: mramotar <mramotar@dropbox.com>
Signed-off-by: mramotar <mramotar@dropbox.com>
Signed-off-by: mramotar <mramotar@dropbox.com>
Signed-off-by: mramotar <mramotar@dropbox.com>
digitalbuddha
approved these changes
Dec 21, 2022
matt-ramotar
added a commit
that referenced
this pull request
Jan 3, 2023
* Stub Store write Signed-off-by: mramotar <mramotar@dropbox.com> * Format Signed-off-by: mramotar <mramotar@dropbox.com> * Compile Signed-off-by: mramotar <mramotar@dropbox.com> * Fix tests Signed-off-by: mramotar <mramotar@dropbox.com> * Stash M1 Signed-off-by: mramotar <mramotar@dropbox.com> * Make Updater and Bookkeeper optional Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add conflict resolution Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Cover simple write Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add MutableStore Signed-off-by: mramotar <mramotar@dropbox.com> * Add RealMutableStore Signed-off-by: mramotar <mramotar@dropbox.com> * Update workflows Signed-off-by: mramotar <mramotar@dropbox.com> * Format Signed-off-by: mramotar <mramotar@dropbox.com> * Remove references to Market Signed-off-by: mramotar <mramotar@dropbox.com> * Remove Converter interface Signed-off-by: mramotar <mramotar@dropbox.com> * Move Converter typealias Signed-off-by: mramotar <mramotar@dropbox.com> * Remove Google copyright Signed-off-by: mramotar <mramotar@dropbox.com> * Update CHANGELOG.md Signed-off-by: mramotar <mramotar@dropbox.com> Signed-off-by: mramotar <mramotar@dropbox.com> Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
digitalbuddha
pushed a commit
that referenced
this pull request
Jan 16, 2023
* Stub Store write Signed-off-by: mramotar <mramotar@dropbox.com> * Format Signed-off-by: mramotar <mramotar@dropbox.com> * Compile Signed-off-by: mramotar <mramotar@dropbox.com> * Fix tests Signed-off-by: mramotar <mramotar@dropbox.com> * Stash M1 Signed-off-by: mramotar <mramotar@dropbox.com> * Make Updater and Bookkeeper optional Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add conflict resolution Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Cover simple write Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add MutableStore Signed-off-by: mramotar <mramotar@dropbox.com> * Add RealMutableStore Signed-off-by: mramotar <mramotar@dropbox.com> * Update workflows Signed-off-by: mramotar <mramotar@dropbox.com> * Format Signed-off-by: mramotar <mramotar@dropbox.com> * Remove references to Market Signed-off-by: mramotar <mramotar@dropbox.com> * Remove Converter interface Signed-off-by: mramotar <mramotar@dropbox.com> * Move Converter typealias Signed-off-by: mramotar <mramotar@dropbox.com> * Remove Google copyright Signed-off-by: mramotar <mramotar@dropbox.com> * Update CHANGELOG.md Signed-off-by: mramotar <mramotar@dropbox.com> Signed-off-by: mramotar <mramotar@dropbox.com> Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
digitalbuddha
pushed a commit
that referenced
this pull request
Jan 16, 2023
* Stub Store write Signed-off-by: mramotar <mramotar@dropbox.com> * Format Signed-off-by: mramotar <mramotar@dropbox.com> * Compile Signed-off-by: mramotar <mramotar@dropbox.com> * Fix tests Signed-off-by: mramotar <mramotar@dropbox.com> * Stash M1 Signed-off-by: mramotar <mramotar@dropbox.com> * Make Updater and Bookkeeper optional Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add conflict resolution Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Cover simple write Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add MutableStore Signed-off-by: mramotar <mramotar@dropbox.com> * Add RealMutableStore Signed-off-by: mramotar <mramotar@dropbox.com> * Update workflows Signed-off-by: mramotar <mramotar@dropbox.com> * Format Signed-off-by: mramotar <mramotar@dropbox.com> * Remove references to Market Signed-off-by: mramotar <mramotar@dropbox.com> * Remove Converter interface Signed-off-by: mramotar <mramotar@dropbox.com> * Move Converter typealias Signed-off-by: mramotar <mramotar@dropbox.com> * Remove Google copyright Signed-off-by: mramotar <mramotar@dropbox.com> * Update CHANGELOG.md Signed-off-by: mramotar <mramotar@dropbox.com> Signed-off-by: mramotar <mramotar@dropbox.com> Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see our contributing guidelines (contributing.md) primarily make sure to sign our cla as we cannot accept code externally without a signed cla
https://opensource.dropbox.com/cla/