Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Store 5] Make Bookkeeper optional #452

Closed
matt-ramotar opened this issue Sep 15, 2022 · 2 comments
Closed

[Store 5] Make Bookkeeper optional #452

matt-ramotar opened this issue Sep 15, 2022 · 2 comments

Comments

@matt-ramotar
Copy link
Collaborator

As I wrote internally - I am not sure we need to require users pass in Bookkeeper. All Bookkeper needs to do is let RealMarket know it should eagerly resolve conflicts. Initially I thought we would want to defer implementation to users. But with Bookkeeping mental model, I suspect most users will not care to customize. We can bind Bookkeeper to a disk cache or DB ourselves under the hood and make it default implementation. Thoughts on making Bookkeeper optional?

Originally posted by @matt-ramotar in #450 (comment)

@matt-ramotar matt-ramotar changed the title Make Bookkeeper optional [Store 5] Make Bookkeeper optional Sep 15, 2022
@aclassen
Copy link
Contributor

Just wanna note, that if we wanna go for disk cache we would also need a kmp filesystem implementation. So i guess a DB would be a better fit to support all platforms.

@matt-ramotar
Copy link
Collaborator Author

Closing as #496 separated Store and MutableStore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants