Merge pull request Checkmk#564 from Mik3yZ/devel

Change logic in rule.py irt conditions being overwritten
Mik3yZ · Feb 21, 2024 · ff80cdf · ff80cdf
2 parents 12f8f94 + ebbc087
commit ff80cdf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/fragments/fix_rule_conditions_missing.yml b/changelogs/fragments/fix_rule_conditions_missing.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Rule module - Fix empty rule conditions.
diff --git a/plugins/modules/rule.py b/plugins/modules/rule.py
@@ -583,7 +583,7 @@ def run_module():
         if not rule.get("value_raw"):
             exit_failed(module, "Rule value_raw is required")
         # Default to all hosts if conditions arent given
-        if rule.get("conditions"):
+        if not rule.get("conditions"):
             rule["conditions"] = {
                 "host_tags": [],
                 "host_labels": [],
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- Rule module - Fix empty rule conditions.