Change logic in rule.py irt conditions being overwritten

[Mik3yZ]

This always filled rule["conditions"] with a empty dict, when conditions were defined. (and didn't fill it with an empty dict when there are no conditions).

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

rule["conditions"] gets overwritten with an empty default dict, when the rule definition contains conditions. The logic is wrong.

What is the new behavior?

Changed to logic so it works as expected.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[Mik3yZ]

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

[Mik3yZ]

recheck

[lgetwan]

Hi Mike!

Thanks for finding and solving this bug.
By coincidence, I created a duplicate PR with the same solution. ;-)
I will put my changelog into your PR and close mine as duplicate.

Cheers
Lars

[lgetwan]

@Mik3yZ,
For some reason I'm not able to checkout your PR. Can you add a changelog like this?

$ cat changelogs/fragments/fix_rule_conditions_missing.yml 
bugfixes:
 - Rule module - Fix empty rule conditions.

[lgetwan]

@Mik3yZ,
This fix was released with yesterday's 4.3.1 version.