Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIR inconsistency with globals #931

Merged
merged 3 commits into from
May 6, 2020
Merged

Fix SIR inconsistency with globals #931

merged 3 commits into from
May 6, 2020

Conversation

jdahm
Copy link
Contributor

@jdahm jdahm commented Apr 20, 2020

Technical Description

Fix SIR inconsistency in serialization/deserialization.

@jdahm
Copy link
Contributor Author

jdahm commented Apr 20, 2020

launch jenkins

twicki
twicki reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdahm jdahm mentioned this pull request Apr 20, 2020
Closed
@jdahm
Copy link
Contributor Author

jdahm commented May 6, 2020

launch jenkins

@jdahm jdahm merged commit 91a90d6 into MeteoSwiss-APN:master May 6, 2020
@jdahm jdahm deleted the workaround_sir_global_inconsistency branch May 6, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twicki twicki twicki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdahm @twicki