Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global variables in SIR should not always need value #934

Closed
jdahm opened this issue Apr 20, 2020 · 2 comments
Closed

Global variables in SIR should not always need value #934

jdahm opened this issue Apr 20, 2020 · 2 comments

Comments

@jdahm
Copy link
Contributor

jdahm commented Apr 20, 2020

We cannot deserialize globals without a value set. In fact, in this case there is no information about the data type written into the SIR. This situation needs fixing so there is a clear bijection between the in-memory and serialization.

Relevant code references:

#931 fixes the immediate bug by using default initialization, but this is only a temporary fix. Long-term we need to allow unset globals, if globals are necessary...

@Stagno
Copy link
Contributor

Stagno commented Apr 21, 2020

I think it's worth to first re-discuss globals to see if we really need them or if there is a better way to have the functionality of a constant (within the stencil) value which is domain-global, then see how to fix this, if it will be needed.

@jdahm
Copy link
Contributor Author

jdahm commented May 6, 2020

We have a work-around implemented in #931.

@jdahm jdahm closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants