Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redesign Confirmation bold font weight text #13706

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Redesign Confirmation bold font weight text #13706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
092b02c
fix: set confirm account name and Message to fontStyles.bold
digiwand Feb 25, 2025
010b586
style : rm unnecessary fontWeight
digiwand Feb 25, 2025
80589d2
fix: Expandable Message font weight
digiwand Feb 25, 2025
03c04db
fix: confirmation font weights
digiwand Feb 25, 2025
f340cbc
fix: lint error Animated.Text InfoSectionAccordion
digiwand Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...firm/AccountNetworkInfo/AccountNetworkInfoCollapsed/AccountNetworkInfoCollapsed.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ const styleSheet = (params: { theme: Theme }) => {
},
accountName: {
color: theme.colors.text.default,
...fontStyles.normal,
...fontStyles.bold,
fontSize: 14,
fontWeight: '500',
},
networkName: {
color: theme.colors.text.default,
...fontStyles.normal,
fontSize: 14,
fontWeight: '400',
},
});
};
Expand Down
3 changes: 1 addition & 2 deletions app/components/Views/confirmations/components/Confirm/Info/TypedSignV3V4/Message.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ const styleSheet = (params: { theme: Theme }) => {
},
title: {
color: theme.colors.text.default,
...fontStyles.normal,
...fontStyles.bold,
fontSize: 14,
fontWeight: '500',
marginBottom: 16,
},
});
Expand Down
1 change: 0 additions & 1 deletion ...ents/Confirm/Info/TypedSignV3V4/Simulation/components/ValueDisplay/ValueDisplay.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ const styleSheet = (colors: Theme['colors']) =>
color: colors.text.default,
...fontStyles.bold,
fontSize: 14,
fontWeight: '700',
textAlign: 'center',
width: '100%',
// height of header icon
Expand Down
5 changes: 1 addition & 4 deletions ...onfirmations/components/Confirm/SignatureMessageSection/SignatureMessageSection.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,14 @@ const styleSheet = (params: { theme: Theme }) => {
},
title: {
color: theme.colors.text.default,
...fontStyles.normal,
...fontStyles.bold,
fontSize: 14,
fontWeight: '500',
marginBottom: 4,
},
description: {
color: theme.colors.text.default,
...fontStyles.normal,
fontSize: 14,
fontWeight: '400',
},
messageContainer: {
backgroundColor: theme.colors.background.default,
Expand All @@ -40,7 +38,6 @@ const styleSheet = (params: { theme: Theme }) => {
color: theme.colors.text.default,
...fontStyles.normal,
fontSize: 14,
fontWeight: '400',
},
copyButtonContainer: {
position: 'absolute',
Expand Down
2 changes: 0 additions & 2 deletions app/components/Views/confirmations/components/Confirm/Title/Title.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@ const styleSheet = (params: { theme: Theme }) => {
color: theme.colors.text.default,
...fontStyles.bold,
fontSize: 18,
fontWeight: '700',
textAlign: 'center',
},
subTitle: {
color: theme.colors.text.default,
...fontStyles.normal,
fontSize: 14,
fontWeight: '400',
marginTop: 8,
textAlign: 'center',
},
Expand Down
1 change: 0 additions & 1 deletion ...omponents/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const styleSheet = (params: { theme: Theme }) => {
color: theme.colors.text.default,
...fontStyles.bold,
fontSize: 14,
fontWeight: '700',
width: '90%',
textAlign: 'center',
},
Expand Down
4 changes: 2 additions & 2 deletions app/components/Views/confirmations/components/UI/InfoRow/InfoRow.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import React from 'react';
import { storiesOf } from '@storybook/react-native';
import { StyleProp, Text, TextStyle, View } from 'react-native';

import { fontStyles } from '../../../../../../styles/common';
import InfoRow from './InfoRow';
import InfoSection from './InfoSection';
import DisplayURL from './InfoValue/DisplayURL';

const style = {
container: { padding: 8 },
title: { marginTop: 20, fontSize: 20, fontWeight: '700' },
title: { marginTop: 20, fontSize: 20, ...fontStyles.bold },
};

storiesOf('Confirmations / InfoRow', module)
Expand Down
1 change: 0 additions & 1 deletion app/components/Views/confirmations/components/UI/InfoRow/InfoRow.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const styleSheet = (params: { theme: Theme }) => {
color: theme.colors.text.default,
...fontStyles.bold,
fontSize: 14,
fontWeight: '500',
alignItems: 'center',
justifyContent: 'center',
},
Expand Down
5 changes: 3 additions & 2 deletions ...nts/Views/confirmations/components/UI/InfoSectionAccordion/InfoSectionAccordion.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { StyleSheet } from 'react-native';
import { Theme } from '../../../../../../util/theme/models';
import { fontStyles } from '../../../../../../styles/common';

const styleSheet = (params: { theme: Theme }) => {
const { theme } = params;
Expand All @@ -22,7 +23,7 @@ const styleSheet = (params: { theme: Theme }) => {
headerTitle: {
color: theme.colors.text.default,
fontSize: 14,
fontWeight: '500',
...fontStyles.bold,
},
icon: {
color: theme.colors.text.muted,
Expand All @@ -32,4 +33,4 @@ const styleSheet = (params: { theme: Theme }) => {
});
};

export default styleSheet;
export default styleSheet;
4 changes: 2 additions & 2 deletions ...omponents/Views/confirmations/components/UI/InfoSectionAccordion/InfoSectionAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const InfoRowAccordion: React.FC<InfoRowAccordionProps> = ({
testID={`${testID}-header`}
>
{typeof header === 'string' ? (
<Animated.Text style={styles.headerTitle}><Text style={styles.headerTitle}>{header}</Text></Animated.Text>
<Animated.Text><Text style={styles.headerTitle}>{header}</Text></Animated.Text>
) : (
header
)}
Expand All @@ -130,4 +130,4 @@ const InfoRowAccordion: React.FC<InfoRowAccordionProps> = ({
);
};

export default InfoRowAccordion;
export default InfoRowAccordion;
4 changes: 2 additions & 2 deletions app/components/Views/confirmations/components/UI/TextWithTooltip/TextWithTooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import React from 'react';
import { storiesOf } from '@storybook/react-native';
import { StyleProp, Text, TextStyle, View } from 'react-native';

import { fontStyles } from '../../../../../../styles/common';
import TextWithTooltip from '.';

const style = {
container: { padding: 8 },
title: { marginTop: 20, fontSize: 20, fontWeight: '700' },
title: { marginTop: 20, fontSize: 20, ...fontStyles.bold },
};

storiesOf('Confirmations / TextWithTooltip', module)
Expand Down
1 change: 0 additions & 1 deletion app/components/Views/confirmations/components/UI/Tooltip/Tooltip.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const styleSheet = (params: { theme: Theme, vars: { title: string } }) => {
color: theme.colors.text.default,
...fontStyles.bold,
fontSize: 16,
fontWeight: '700',
marginTop: 8,
},
modalContent: {
Expand Down
Loading