Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redesign Confirmation bold font weight text #13706

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Feb 25, 2025

Description

Some text that was meant to be bold is not displaying as bold. This can be observed in Android. It is not visible in iOS.

We should not specify font weights ourselves. Instead, we should opt-in for fontStyles.

e.g. using font-weight 700 when we have not declared a font to display for the weight may cause a different font weight of the font to display.

It seems we specify specific font families too rather than mapping the fonts to a common font family name

  normal: {
    fontFamily: 'EuclidCircularB-Regular',
    fontWeight: '400',
  },
  bold: {
    fontFamily: 'EuclidCircularB-Bold',
    fontWeight: '600',
  },

Related issues

Fixes: #13705

Manual testing steps

  1. Create permit transaction
  2. Observe network account text and Message

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner February 25, 2025 00:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 25, 2025
we should not specify fontWeights. Let fontStyles define. Mismatch can lead to no boldness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Redesign confirmation font weight bold mismatch
2 participants