chore(runway): cherry-pick Temporarily revert gas included swaps

[runway-github]

• fix: cp-7.41.0 Temporarily revert gas included swaps (fix: cp-7.41.0 Temporarily revert gas included swaps #13639)

Description

Reverts #13430 for now.

We initially believed that resolving the known issue with gas-included
swaps requiring token approval would be easy and could be completed
before the release candidate for version 7.41.0 was pushed to
production, but it turns out that more fundamental changes are needed.
Specifically, submitBatch support from the
TransactionController—allowing the simultaneous submission of multiple
transactions (approval and swap)—is required. This submitBatch support
will likely also be used for current swaps that need token approval to
increase success rates.

Related issues

Fixes: #13584

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots. 7f31286

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f811e1f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53aec2fc-165d-42a8-91c7-7f9aef0a2354

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sethkfman]

LGTM