feat: Add gas included swaps

[dan437]

Description

Users who don't have enough ETH to pay for gas fees while swapping will be able to swap now if the gas fee can be taken from one of the tokens they are swapping. Smart transactions must be enabled for this.

Related issues

Fixes:

Manual testing steps

Test case 1:

1. Make sure you are on Ethereum mainnet and have Smart Transactions on in Advanced Settings
2. Have e.g. 0 ETH and 100 USDC
3. Fill in the swap form with 10 USDC -> ETH
4. You will see gas included swaps UI

Test case 2:

1. Make sure you are on Ethereum mainnet and have Smart Transactions on in Advanced Settings
2. In Swaps you can now click on Use max for ETH
3. Get quotes
4. You will see gas included swaps UI

Screenshots/Recordings

User doesn't have enough ETH for gas fees (gas included swaps):

User has enough ETH for gas fees:

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/swaps-controller@12.1.0 🔁 npm/@metamask/swaps-controller@12.0.0	None	0	304 kB	metamaskbot

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2d94ae8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e9eddaae-1173-46d0-84b8-078b947f4d7d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4888701
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9ce9f1d0-33db-4fc1-a122-901ad0a727c6

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 56.86275% with 22 lines in your changes missing coverage. Please review.

Project coverage is 61.82%. Comparing base (351a276) to head (e24eb98).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
app/components/UI/Swaps/QuotesView.js	43.33%	17 Missing ⚠️
app/core/Engine/Engine.ts	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13430      +/-   ##
==========================================
- Coverage   61.83%   61.82%   -0.01%     
==========================================
  Files        1975     1975              
  Lines       43847    43889      +42     
  Branches     5926     5929       +3     
==========================================
+ Hits        27111    27136      +25     
- Misses      14935    14952      +17     
  Partials     1801     1801              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d9e81cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a7ba152d-0d14-4a5a-b53f-3d68c6b420f5

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 014d439
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/162cd6be-8e4e-41ef-bdec-43b7eac32571

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate failed

Failed conditions
50.8% Coverage on New Code (required ≥ 80%)
13.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

[dan437]

The PR has been merged in order to make it into a release candidate today. There is one known issue which will be resolved in a follow-up PR asap and then cherry picked.