Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support DAI while it's being deprecated #13666

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

digiwand
Copy link
Contributor

Description

Supports DAI while it's being deprecated (see DAI upgrade to USDS).

This PR includes:
#13662 (Empty value display shown)
#13663 (Revoke)

I'll need to resolve merge conflicts when the above two are merged.

Related issues

Fixes: #13336

Manual testing steps

  1. Go to https://develop.d3bkcslj57l47p.amplifyapp.com/
  2. Trigger Permit DAI

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner February 21, 2025 14:43
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 21, 2025
@digiwand digiwand added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 24, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8c21348
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a14b3b8a-76f6-4d68-a0b3-b7d2bde5c649

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@digiwand digiwand added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@digiwand digiwand added this pull request to the merge queue Feb 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing "Unlimited" as value for DAI permit
3 participants