Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide simulation button pill value if no value loaded #13663

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

digiwand
Copy link
Contributor

Description

In case no value was loaded in a permit simulation, then we should not display an empty value ButtonPill component.

Related issues

Fixes: #13662

Manual testing steps

e.g.

  1. Go to https://develop.d3bkcslj57l47p.amplifyapp.com/
  2. Trigger DAI
    We are also fixing this particular issue here: [Bug]: Missing "Unlimited" as value for DAI permit #13336. Adding this PR to be more robust and prevent other outlying cases

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner February 21, 2025 14:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 21, 2025
@digiwand digiwand added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit a91f630 Feb 24, 2025
43 of 46 checks passed
@digiwand digiwand deleted the fix-empty-simulation-button-pill branch February 24, 2025 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Empty value display shown in permit simulation
3 participants