Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UI improvements #13463

Merged
merged 18 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ html-report/
app/util/termsOfUse/termsOfUseContent.ts
docs/assets/termsOfUse.html

/app/images/branding

# build metadata
android/app/src/main/assets/modules.json

Expand Down
Binary file modified android/app/src/flask/res/ic_launcher-playstore.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-hdpi/ic_launcher.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-hdpi/ic_launcher_round.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-mdpi/ic_launcher.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-mdpi/ic_launcher_round.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-xhdpi/ic_launcher.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-xhdpi/ic_launcher_round.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-xxhdpi/ic_launcher.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/flask/res/mipmap-xxxhdpi/ic_launcher.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/main/ic_launcher-playstore.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/main/metamask-logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/main/res/drawable-hdpi/fox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/main/res/drawable-ldpi/fox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified android/app/src/main/res/drawable-mdpi/fox.png
Binary file modified android/app/src/main/res/drawable-night-hdpi/fox.png
Binary file modified android/app/src/main/res/drawable-night-ldpi/fox.png
Binary file modified android/app/src/main/res/drawable-night-mdpi/fox.png
Binary file modified android/app/src/main/res/drawable-night-xhdpi/fox.png
Binary file modified android/app/src/main/res/drawable-night-xxhdpi/fox.png
Binary file modified android/app/src/main/res/drawable-night-xxxhdpi/fox.png
Binary file modified android/app/src/main/res/drawable-night/fox.png
Binary file modified android/app/src/main/res/drawable-xhdpi/fox.png
Binary file modified android/app/src/main/res/drawable-xxhdpi/fox.png
Binary file modified android/app/src/main/res/drawable-xxxhdpi/fox.png
Binary file modified android/app/src/main/res/drawable/fox.png
Binary file modified android/app/src/main/res/ic_launcher_background.png
Binary file modified android/app/src/main/res/ic_launcher_foreground.png
Binary file modified android/app/src/main/res/mipmap-hdpi/ic_launcher.png
Binary file modified android/app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png
Binary file modified android/app/src/main/res/mipmap-hdpi/ic_launcher_round.png
Binary file modified android/app/src/main/res/mipmap-hdpi/ic_notification.png
Binary file modified android/app/src/main/res/mipmap-hdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/main/res/mipmap-hdpi/splash.png
Binary file modified android/app/src/main/res/mipmap-mdpi/ic_launcher.png
Binary file modified android/app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png
Binary file modified android/app/src/main/res/mipmap-mdpi/ic_launcher_round.png
Binary file modified android/app/src/main/res/mipmap-mdpi/ic_notification.png
Binary file modified android/app/src/main/res/mipmap-mdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/main/res/mipmap-mdpi/splash.png
Binary file modified android/app/src/main/res/mipmap-xhdpi/ic_launcher.png
Binary file modified android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png
Binary file modified android/app/src/main/res/mipmap-xhdpi/ic_notification.png
Binary file modified android/app/src/main/res/mipmap-xhdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/main/res/mipmap-xhdpi/splash.png
Binary file modified android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png
Binary file modified android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png
Binary file modified android/app/src/main/res/mipmap-xxhdpi/ic_notification.png
Binary file modified android/app/src/main/res/mipmap-xxhdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/main/res/mipmap-xxhdpi/splash.png
Binary file modified android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
Binary file modified android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png
Binary file modified android/app/src/main/res/mipmap-xxxhdpi/ic_notification.png
Binary file modified android/app/src/main/res/mipmap-xxxhdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/main/res/mipmap-xxxhdpi/splash.png
Binary file modified android/app/src/qa/res/drawable-hdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-ldpi/fox.png
Binary file modified android/app/src/qa/res/drawable-mdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night-hdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night-ldpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night-mdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night-xhdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night-xxhdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night-xxxhdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-night/fox.png
Binary file modified android/app/src/qa/res/drawable-xhdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-xxhdpi/fox.png
Binary file modified android/app/src/qa/res/drawable-xxxhdpi/fox.png
Binary file modified android/app/src/qa/res/drawable/fox.png
Binary file modified android/app/src/qa/res/ic_launcher_background.png
Binary file modified android/app/src/qa/res/ic_launcher_foreground.png
Binary file modified android/app/src/qa/res/mipmap-hdpi/ic_launcher.png
Binary file modified android/app/src/qa/res/mipmap-hdpi/ic_launcher_background.png
Binary file modified android/app/src/qa/res/mipmap-hdpi/ic_launcher_round.png
Binary file modified android/app/src/qa/res/mipmap-hdpi/ic_notification.png
Binary file modified android/app/src/qa/res/mipmap-hdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/qa/res/mipmap-hdpi/splash.png
Binary file modified android/app/src/qa/res/mipmap-mdpi/ic_launcher.png
Binary file modified android/app/src/qa/res/mipmap-mdpi/ic_launcher_background.png
Binary file modified android/app/src/qa/res/mipmap-mdpi/ic_launcher_round.png
Binary file modified android/app/src/qa/res/mipmap-mdpi/ic_notification.png
Binary file modified android/app/src/qa/res/mipmap-mdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/qa/res/mipmap-mdpi/splash.png
Binary file modified android/app/src/qa/res/mipmap-xhdpi/ic_launcher.png
Binary file modified android/app/src/qa/res/mipmap-xhdpi/ic_launcher_background.png
Binary file modified android/app/src/qa/res/mipmap-xhdpi/ic_launcher_round.png
Binary file modified android/app/src/qa/res/mipmap-xhdpi/ic_notification.png
Binary file modified android/app/src/qa/res/mipmap-xhdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/qa/res/mipmap-xhdpi/splash.png
Binary file modified android/app/src/qa/res/mipmap-xxhdpi/ic_launcher.png
Binary file modified android/app/src/qa/res/mipmap-xxhdpi/ic_launcher_round.png
Binary file modified android/app/src/qa/res/mipmap-xxhdpi/ic_notification.png
Binary file modified android/app/src/qa/res/mipmap-xxhdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/qa/res/mipmap-xxhdpi/splash.png
Binary file modified android/app/src/qa/res/mipmap-xxxhdpi/ic_launcher.png
Binary file modified android/app/src/qa/res/mipmap-xxxhdpi/ic_launcher_round.png
Binary file modified android/app/src/qa/res/mipmap-xxxhdpi/ic_notification.png
Binary file modified android/app/src/qa/res/mipmap-xxxhdpi/ic_notification_small.png
100755 → 100644
Binary file modified android/app/src/qa/res/mipmap-xxxhdpi/splash.png
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const SAMPLE_AVATARFAVICON_SVGIMAGESOURCE_REMOTE: ImageSourcePropType = {
uri: 'https://metamask.github.io/test-dapp/metamask-fox.svg',
};
/* eslint-disable-next-line */
export const SAMPLE_AVATARFAVICON_IMAGESOURCE_LOCAL: ImageSourcePropType = require('../../../../../../images/fox.png');
export const SAMPLE_AVATARFAVICON_IMAGESOURCE_LOCAL: ImageSourcePropType = require('../../../../../../images/branding/fox.png');

export const SAMPLE_AVATARFAVICON_PROPS: AvatarFaviconProps = {
imageSource: SAMPLE_AVATARFAVICON_IMAGESOURCE_REMOTE,
Expand Down
2 changes: 1 addition & 1 deletion app/components/Nav/Main/MainNavigator.js
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ const MainNavigator = () => (
headerTitle={() => (
<Image
style={styles.headerLogo}
source={require('../../../images/metamask-name.png')}
source={require('../../../images/branding/metamask-name.png')}
resizeMode={'contain'}
/>
)}
Expand Down
4 changes: 2 additions & 2 deletions app/components/UI/DrawerView/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ const createStyles = (colors) =>
protectWalletButtonWrapper: { marginVertical: 8 },
});

const metamask_name = require('../../../images/metamask-name.png'); // eslint-disable-line
const metamask_fox = require('../../../images/fox.png'); // eslint-disable-line
const metamask_name = require('../../../images/branding/metamask-name.png'); // eslint-disable-line
const metamask_fox = require('../../../images/branding/fox.png'); // eslint-disable-line
const ICON_IMAGES = {
wallet: require('../../../images/wallet-icon.png'), // eslint-disable-line
'selected-wallet': require('../../../images/selected-wallet-icon.png'), // eslint-disable-line
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/FoxLoader/FoxLoader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const FoxLoader = () => {
<Image
style={styles.image}
// eslint-disable-next-line @typescript-eslint/no-require-imports
source={require('../../../images/fox.png')}
source={require('../../../images/branding/fox.png')}
resizeMode="contain"
/>
<View style={styles.spacer} />
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/FoxScreen/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const createStyles = (colors) =>
},
});

const foxImage = require('../../../images/fox.png'); // eslint-disable-line import/no-commonjs
const foxImage = require('../../../images/branding/fox.png'); // eslint-disable-line import/no-commonjs

/**
* View component that displays the MetaMask fox
Expand Down
54 changes: 22 additions & 32 deletions app/components/UI/Navbar/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ const trackEvent = (event, params = {}) => {

const styles = StyleSheet.create({
metamaskName: {
width: 122,
height: 15,
width: 70,
height: 35,
},
metamaskFox: {
width: 40,
Expand Down Expand Up @@ -148,8 +148,8 @@ const styles = StyleSheet.create({
},
});

const metamask_name = require('../../../images/metamask-name.png'); // eslint-disable-line
const metamask_fox = require('../../../images/fox.png'); // eslint-disable-line
const metamask_name = require('../../../images/branding/metamask-name.png'); // eslint-disable-line
const metamask_fox = require('../../../images/branding/fox.png'); // eslint-disable-line
/**
* Function that returns the navigation options
* This is used by views that will show our custom navbar
Expand Down Expand Up @@ -651,8 +651,8 @@ export function getOnboardingNavbarOptions(
elevation: 0,
},
metamaskName: {
width: 122,
height: 15,
width: 70,
height: 35,
tintColor: themeColors.text.default,
},
});
Expand Down Expand Up @@ -688,8 +688,8 @@ export function getTransparentOnboardingNavbarOptions(themeColors) {
elevation: 0,
},
metamaskName: {
width: 122,
height: 15,
width: 70,
height: 35,
tintColor: themeColors.text.default,
},
});
Expand Down Expand Up @@ -722,8 +722,8 @@ export function getTransparentBackOnboardingNavbarOptions(themeColors) {
elevation: 0,
},
metamaskName: {
width: 122,
height: 15,
width: 70,
height: 35,
tintColor: themeColors.text.default,
},
});
Expand Down Expand Up @@ -756,36 +756,26 @@ export function getOptinMetricsNavbarOptions(themeColors) {
backgroundColor: themeColors.background.default,
shadowColor: importedColors.transparent,
elevation: 0,
height: 100,
},
metamaskName: {
width: 122,
height: 15,
width: 70,
height: 35,
tintColor: themeColors.text.default,
},
});

return {
headerStyle: innerStyles.headerStyle,
title: null,
headerLeft: () => (
<View style={styles.optinHeaderLeft}>
<View style={styles.metamaskNameWrapper}>
<Image
source={metamask_fox}
style={styles.metamaskFox}
resizeMethod={'auto'}
/>
</View>
<View style={styles.metamaskNameWrapper}>
<Image
source={metamask_name}
style={innerStyles.metamaskName}
resizeMethod={'auto'}
/>
</View>
headerTitle: () => (
<View style={styles.metamaskNameTransparentWrapper}>
<Image
source={metamask_name}
style={innerStyles.metamaskName}
resizeMethod={'auto'}
/>
</View>
),
headerBackTitle: strings('navigation.back'),
headerRight: () => <View />,
headerStyle: innerStyles.headerStyle,
headerTintColor: themeColors.primary.default,
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Badge, {
} from '../../../../component-library/components/Badges/Badge';
import { BOTTOM_BADGEWRAPPER_BADGEPOSITION } from '../../../../component-library/components/Badges/BadgeWrapper/BadgeWrapper.constants';
import RemoteImage from '../../../../components/Base/RemoteImage';
import METAMASK_FOX from '../../../../images/fox.png';
import METAMASK_FOX from '../../../../images/branding/fox.png';
import { View } from 'react-native';

type NotificationIconProps = Pick<
Expand Down
77 changes: 19 additions & 58 deletions app/components/UI/OptinMetrics/__snapshots__/index.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ exports[`OptinMetrics render matches snapshot 1`] = `
pointerEvents="box-none"
style={
{
"height": 100,
"height": 64,
"maxHeight": undefined,
"minHeight": undefined,
"opacity": undefined,
Expand Down Expand Up @@ -106,89 +106,49 @@ exports[`OptinMetrics render matches snapshot 1`] = `
pointerEvents="box-none"
style={
{
"alignItems": "flex-start",
"bottom": 0,
"justifyContent": "center",
"left": 0,
"marginHorizontal": 16,
"opacity": 1,
"position": "absolute",
"top": 0,
}
}
>
<View
style={
{
"alignItems": "center",
"flexDirection": "row",
"marginHorizontal": 20,
"flex": 1,
"justifyContent": "center",
}
}
>
<View
style={
{
"marginLeft": 0,
}
}
>
<Image
resizeMethod="auto"
source={1}
style={
{
"height": 40,
"marginRight": 10,
"width": 40,
}
}
/>
</View>
<View
<Image
resizeMethod="auto"
source={1}
style={
{
"marginLeft": 0,
"height": 35,
"tintColor": "#141618",
"width": 70,
}
}
>
<Image
resizeMethod="auto"
source={1}
style={
{
"height": 15,
"tintColor": "#141618",
"width": 122,
}
}
/>
</View>
/>
</View>
</View>
<View
collapsable={false}
pointerEvents="box-none"
style={
{
"marginHorizontal": 72,
"alignItems": "flex-end",
"bottom": 0,
"justifyContent": "center",
"opacity": 1,
"position": "absolute",
"right": 0,
"top": 0,
}
}
>
<Text
accessibilityRole="header"
aria-level="1"
collapsable={false}
numberOfLines={1}
onLayout={[Function]}
style={
{
"color": "#0376c9",
"fontSize": 17,
"fontWeight": "600",
}
}
/>
<View />
</View>
</View>
</View>
Expand Down Expand Up @@ -391,6 +351,7 @@ exports[`OptinMetrics render matches snapshot 1`] = `
style={
{
"marginHorizontal": 20,
"marginTop": 10,
}
}
>
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/OptinMetrics/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
BackHandler,
Alert,
Linking,
InteractionManager,
TouchableOpacity,
} from 'react-native';
import PropTypes from 'prop-types';
Expand Down Expand Up @@ -98,6 +97,7 @@ const createStyles = ({ colors }) =>
paddingVertical: 10,
},
wrapper: {
marginTop: 10,
marginHorizontal: 20,
},
privacyPolicy: {
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/PhishingModal/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const createStyles = (colors) =>
},
});

const foxImage = require('../../../images/fox.png'); // eslint-disable-line import/no-commonjs
const foxImage = require('../../../images/branding/fox.png'); // eslint-disable-line import/no-commonjs

export default class PhishingModal extends PureComponent {
static propTypes = {
Expand Down
Loading
Loading