Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: UI improvements #13463

Merged
merged 18 commits into from
Feb 13, 2025
Merged

chore: UI improvements #13463

merged 18 commits into from
Feb 13, 2025
+3,025 −4,247

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Feb 12, 2025 •
edited
Loading

Description

Related issues

Fixes:

Manual testing steps

  1. Freshly install the app and go through both flows of creating a wallet and importing a wallet. Make sure word marks and logo marks have changed
  2. FOR IOS ONLY - Tap and hold onto the home screen until the app icons jiggle, click on the edit button on the top left or right depending on device, switch to dark mode to confirm that the app icon changes to dark mode.
  3. Make sure the onboarding is updated with new assets
  4. Go through the entire app to make sure there are no remnants of the old branding

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward
feat: replace common icons with new icons
b711b67
@vinnyhoward
feat: replace all 3D instances of mascot with temp png version
e7db611
@vinnyhoward
Merge branch 'develop' into feat-3931-rebrand-phase-1
21290e5
@vinnyhoward
feat: updated main app icons for android and all icons for iOS includ…
660cdb4 
…ing splash pages for both platforms
@vinnyhoward
fix: update snaps
4033f36
@vinnyhoward
feat: update QA and flask build icons
19aa585
@vinnyhoward
fix: fix header alignment during opt in step when creating wallet
c144808
@vinnyhoward
fix: android QA build assets were being cached and not changing. Chan…
501a633 
…ged asset file URL paths to break caching issues
@vinnyhoward
fix: removed .gitignore file path for branding assets
65e2e02
@vinnyhoward
fix: fixed header being too close to onboarding steps. re-added shape…
fadfbab 
…s and logo animation for swap flow
@vinnyhoward
fix: update snaps
ec343a1
@vinnyhoward
fix: updated UI and fixed regressions from last design review
307ac7f
@vinnyhoward vinnyhoward requested review from a team as code owners February 12, 2025 17:16
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added team-wallet-ux team-assets team-ramp issues related to Ramp features team-swaps team-design-system All issues relating to design system in Mobile team-mobile-platform Mobile Platform team Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8e62315
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b502e13-59e7-4619-a690-6bfa73f0a9ab

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 12, 2025
@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cbb1ee9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a057864-37c4-4a82-a162-1aa483d0d291

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
3.1% Duplication on New Code

See analysis details on SonarQube Cloud

Prithpal-Sooriya
Prithpal-Sooriya approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on notifications side

EtherWizard33
EtherWizard33 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving following previous approval (other repo)

wachunei
wachunei approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramp changes LGTM

@NidhiKJha NidhiKJha enabled auto-merge February 13, 2025 14:55
brianacnguyen
brianacnguyen requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested

This was referenced Feb 13, 2025
Closed
Closed
@vinnyhoward
Copy link
Contributor Author

vinnyhoward commented Feb 13, 2025 •
edited
Loading

Here are the tickets for your requests, I will do a fast follow according to your recommendations #13491 #13492 @brianacnguyen

brianacnguyen
brianacnguyen approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with #13491 #13492 follow-up tickets

@NidhiKJha NidhiKJha added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 351a276 Feb 13, 2025
43 checks passed
@vinnyhoward vinnyhoward deleted the chore-ui-improvements branch February 13, 2025 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

@ejwessel ejwessel ejwessel approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

Assignees
No one assigned
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets team-design-system All issues relating to design system in Mobile team-mobile-platform Mobile Platform team team-ramp issues related to Ramp features team-swaps team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vinnyhoward @wachunei @ejwessel @brianacnguyen @Prithpal-Sooriya @NidhiKJha @EtherWizard33 @metamaskbot