Skip to content

Commit

Permalink
fix(13491): update wallet creation flow styles (#13501)
Browse files Browse the repository at this point in the history
## **Description**

Follow up fixes for [this
PR](#13463)

## **Related issues**

Fixes:
[#13491](#13491)

## **Manual testing steps**

1. During wallet sign up flow notice that the view is slightly farther
from header
2.
3.

## **Screenshots/Recordings**

NA

### **Before**

NA

### **After**

NA

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
vinnyhoward authored Feb 13, 2025
1 parent 351a276 commit ed21162
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ exports[`AccountBackupStep1 should render correctly 1`] = `
style={
{
"flex": 1,
"marginTop": 15,
"marginTop": 16,
"padding": 20,
"paddingBottom": 0,
"paddingTop": 0,
Expand Down
8 changes: 4 additions & 4 deletions app/components/Views/AccountBackupStep1/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const createStyles = (colors) =>
padding: 20,
paddingTop: 0,
paddingBottom: 0,
marginTop: 15,
marginTop: 16,
},
content: {
alignItems: 'center',
Expand Down Expand Up @@ -131,9 +131,9 @@ const AccountBackupStep1 = (props) => {
const styles = createStyles(colors);

const track = (event, properties) => {
const eventBuilder = MetricsEventBuilder.createEventBuilder(event);
eventBuilder.addProperties(properties);
trackOnboarding(eventBuilder.build());
const eventBuilder = MetricsEventBuilder.createEventBuilder(event);
eventBuilder.addProperties(properties);
trackOnboarding(eventBuilder.build());
};

useEffect(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ exports[`AccountBackupStep1B should render correctly 1`] = `
style={
{
"flex": 1,
"marginTop": 15,
"marginTop": 16,
"padding": 20,
"paddingBottom": 0,
"paddingTop": 0,
Expand Down
2 changes: 1 addition & 1 deletion app/components/Views/AccountBackupStep1B/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const createStyles = (colors) =>
padding: 20,
paddingTop: 0,
paddingBottom: 0,
marginTop: 15,
marginTop: 16,
},
content: {
alignItems: 'center',
Expand Down
4 changes: 2 additions & 2 deletions app/components/Views/ChoosePassword/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ import navigateTermsOfUse from '../../../util/termsOfUse/termsOfUse';
import { ChoosePasswordSelectorsIDs } from '../../../../e2e/selectors/Onboarding/ChoosePassword.selectors';
import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding';
import { enableProfileSyncing } from '../../../actions/identity';
import {MetricsEventBuilder} from '../../../core/Analytics/MetricsEventBuilder';
import { MetricsEventBuilder } from '../../../core/Analytics/MetricsEventBuilder';
const createStyles = (colors) =>
StyleSheet.create({
mainWrapper: {
Expand All @@ -73,7 +73,7 @@ const createStyles = (colors) =>
wrapper: {
flex: 1,
marginBottom: 10,
marginTop: 15,
marginTop: 16,
},
scrollableWrapper: {
flex: 1,
Expand Down
2 changes: 1 addition & 1 deletion app/components/Views/ManualBackupStep1/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const createStyles = (colors: any) =>
mainWrapper: {
backgroundColor: colors.background.default,
flex: 1,
marginTop: 15,
marginTop: 16,
},
wrapper: {
flex: 1,
Expand Down
2 changes: 1 addition & 1 deletion app/components/Views/ManualBackupStep2/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const createStyles = (colors: any) =>
mainWrapper: {
backgroundColor: colors.background.default,
flex: 1,
marginTop: 15,
marginTop: 16,
},
wrapper: {
flex: 1,
Expand Down
8 changes: 4 additions & 4 deletions app/components/Views/ManualBackupStep3/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const createStyles = (colors) =>
mainWrapper: {
backgroundColor: colors.background.default,
flex: 1,
marginTop: 15,
marginTop: 16,
},
actionView: {
paddingTop: 40,
Expand Down Expand Up @@ -175,9 +175,9 @@ class ManualBackupStep3 extends PureComponent {
JSON.stringify({ ...parsedHints, manualBackup: hintText }),
);
trackOnboarding(
MetricsEventBuilder.createEventBuilder(
MetaMetricsEvents.WALLET_SECURITY_RECOVERY_HINT_SAVED,
).build(),
MetricsEventBuilder.createEventBuilder(
MetaMetricsEvents.WALLET_SECURITY_RECOVERY_HINT_SAVED,
).build(),
);
};

Expand Down

0 comments on commit ed21162

Please sign in to comment.