Enable the Token Allowance flow by default for all users #16740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PeterYinusa
reviewed
Dec 1, 2022
| @@ -1,362 +1,506 @@ | |||
| /* eslint-disable mocha/no-skipped-tests */ | |||
There was a problem hiding this comment.
@mirjanaKukic can we remove this line now? I don't believe its needed anymore
Builds ready [f751878]
Page Load Metrics (1976 ± 99 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
658db12 to
88ec6a0
Compare
Builds ready [88ec6a0]
Page Load Metrics (1991 ± 78 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
|
Verified by QA |
Builds ready [f4b50ef]
Page Load Metrics (2235 ± 143 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
f4b50ef to
ad29194
Compare
Builds ready [ad29194]
Page Load Metrics (2302 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
ad29194 to
aa8537f
Compare
Builds ready [aa8537f]
Page Load Metrics (2463 ± 239 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
aa8537f to
79cb332
Compare
Builds ready [79cb332]
Page Load Metrics (2177 ± 94 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
6 tasks
79cb332 to
c548e58
Compare
Builds ready [745ecee]
Page Load Metrics (2238 ± 128 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
Builds ready [9c0bd95]
Page Load Metrics (1179 ± 105 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
9c0bd95 to
1c50a86
Compare
Builds ready [1c50a86]
Page Load Metrics (1449 ± 149 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights:storybook
|
Builds ready [660f03d]
Page Load Metrics (1107 ± 93 ms)
highlights:storybook
|
pedronfigueiredo
previously approved these changes
Jan 20, 2023
Fixing lint verify locales changed add approve token tests skipped approve token tests from metamask-ui file added test for max spending cap failOnConsoleError removed tests from metamask-ui fix add delay removed failOnConsoleError
660f03d to
b686323
Compare
Builds ready [b686323]
Page Load Metrics (1459 ± 123 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
darkwing
reviewed
Jan 23, 2023
| </Button> | ||
| {setshowContractDetails && ( | ||
| <ContractDetailsModal | ||
| onClose={() => this.setState({ setshowContractDetails: false })} |
There was a problem hiding this comment.
In a follow up PR we should change setshowContractDetails to setShowContractDetails but I won't block on that.
darkwing
approved these changes
Jan 23, 2023
jpuri
reviewed
Jan 23, 2023
| new Date(UI_NOTIFICATIONS[16].date), | ||
| ) | ||
| : '', | ||
| }, | ||
| 17: { |
jpuri
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Token Allowanceflow by default for all users.Token Allowancefeature.What's Newnotification which prompted users to turn on the setting.Experimental toggleforToken Allowancefeature.Screenshots/Screencaps
Before
After
Test-Dapp
Screen.Recording.2022-11-30.at.12.24.05.mov
Etherscan
Screen.Recording.2022-11-30.at.12.27.26.mov
Manual Testing Steps
Test-dapp
Create TokenApprove Tokensor
Approve Tokens Without GasEtherscan
approveinput any address and number