Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Approve Tokens legacy screen displays wrong decimal numbers for Token #16686

Closed
seaona opened this issue Nov 25, 2022 · 5 comments · Fixed by #16934
Closed

[Bug]: Approve Tokens legacy screen displays wrong decimal numbers for Token #16686

seaona opened this issue Nov 25, 2022 · 5 comments · Fixed by #16934
Assignees
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working
Milestone

Comments

@seaona
Copy link
Contributor

seaona commented Nov 25, 2022

Describe the bug

Problem: the legacy screen for Approve Tokens, displays the wrong decimal numbers on the token balance when the user clicks on Edit permissions.

approve-tokens-legacy

Steps to reproduce

  1. Go to the test dapp https://metamask.github.io/test-dapp/
  2. Connect MM
  3. Click Create Token
  4. Accept tx on MM
  5. Click Approve Tokens
  6. Click Edit permissions on MM popup - check top balance is displaying the wrong decimal numbers / compare to the value below the screen

Error messages or log output

No response

Version

10.23.0

Build type

No response

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

@seaona seaona added type-bug Something isn't working regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Nov 25, 2022
@seaona seaona added this to the v10.23.0 milestone Nov 25, 2022
@VSaric
Copy link
Contributor

VSaric commented Dec 1, 2022

I think this will be solved by this #16623 which will make the new flow default (and the new flow doesn't have Edit permission screen anymore).
cc: @seaona @bschorchit

@PeterYinusa PeterYinusa modified the milestones: v10.23.0, v10.24.0 Dec 6, 2022
@digiwand
Copy link
Contributor

assigning to @VSaric as it looks like their PR fixes this issue
#16740

@bschorchit
Copy link

bschorchit commented Dec 13, 2022

We cannot merge #16740 for 10.24 though :/

The new token allowance flow has yet to be released under Settings > Experimental before we can make it the default flow on a later release. The target is to merge it for 10.25 if all goes well while this feature is under experimental.

@digiwand
Copy link
Contributor

ooh. I see. Thanks for the info @bschorchit

@digiwand digiwand assigned digiwand and unassigned VSaric Dec 13, 2022
@digiwand
Copy link
Contributor

looking into this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working
Projects
None yet
5 participants