Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Refactor send-hex-address spec using Ganache seeder #15604

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Aug 16, 2022

Explanation

The main goal is to deploy the e2e smart contracts directly on Ganache, instead of using the Dapp Test interface for achieving the same actions.
These smart contracts can be used later within the e2e tests in order to reduce the amount of code needed to be written in order to execute the same action every time for each of the tests (i.e. contract deployment). This would also reduce the time needed for e2e tests execution because waiting for the UI action response will be eliminated.

More Information

The first task took care of preparing the contracts and the seeder, so it deploys correctly any contract we pass them into Ganache, from the background. First PR is already merged here #14631

The second part will take care of the refactor of the e2e testcases, in order to use the smart contract deployer, instead of deploying each contract manually, using the Dapp UI.

Manual Testing Steps

Run testcase locally or check ci pipeline and ensure that it continues to work normally:
yarn test:e2e:single test/e2e/tests/send-hex-address.spec.js

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@seaona seaona added the needs-qa Label will automate into QA workspace label Aug 16, 2022
@seaona seaona requested a review from a team as a code owner August 16, 2022 13:39
@seaona seaona self-assigned this Aug 16, 2022
@seaona seaona requested a review from garrettbear August 16, 2022 13:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [5884b5e]
Page Load Metrics (1884 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932591193517
domContentLoaded16822096186811857
load17012193188413665
domInteractive16822096186811857

PeterYinusa
PeterYinusa previously approved these changes Aug 17, 2022
brad-decker
brad-decker previously approved these changes Sep 8, 2022
@seaona seaona dismissed stale reviews from brad-decker and PeterYinusa via cc811ba September 13, 2022 09:43
@metamaskbot
Copy link
Collaborator

Builds ready [cc811ba]
Page Load Metrics (1914 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint981948205400192
domContentLoaded1737204318857938
load1737205919148943
domInteractive1737204318857938

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona merged commit 506d1e7 into develop Sep 14, 2022
@seaona seaona deleted the send-hex-ganache-refactor branch September 14, 2022 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Label will automate into QA workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants