Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor e2e testcases for implement smart contract deployment on the background using ganache seeder #15417

Open
5 of 7 tasks
seaona opened this issue Aug 2, 2022 · 0 comments
Assignees
Labels
needs-qa Label will automate into QA workspace team-extension-platform Extension Platform team

Comments

@seaona
Copy link
Contributor

seaona commented Aug 2, 2022

Goal

The main goal is to deploy the smart contracts directly on Ganache, instead of using the Dapp Test interface for achieving the same actions.
These smart contracts can be used later within the e2e tests in order to reduce the amount of code needed to be written in order to execute the same action every time for each of the tests (i.e. contract deployment). This would also reduce the time needed for e2e tests execution because waiting for the UI action response will be eliminated.

Approach

We are going to split this task in 2 parts. The first one will take care of preparing the contracts and the seeder, so it deploys correctly any contract we pass them into Ganache, from the background.
First PR is already merged here
#14631

The second part will take care of the refactor of the e2e testcases, in order to use the smart contract deployer, instead of deploying each contract manually, using the Dapp UI.

  • contract-interactions.specs.js PR #15553
  • collectibles.specs.js
  • custom-token-add-approve.specs.js PR #15728
  • failing-contract.specs.js PR #15601
  • send-hex-address.specs.js PR #15604
  • send-to-contract.specs.js PR #15605
  • metamask-ui.specs.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Label will automate into QA workspace team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants