Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update accounts-related packages versioning for new scopes feature #5136

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: update accounts-related packages versioning for new scopes feature #5136

merged 1 commit into from
Jan 13, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 13, 2025 •
edited
Loading

Explanation

Some accounts packages were not properly versioned when introducing the new scopes feature. This has now been fixed and this PR bumps each accounts packages accordingly.

References

Changelog

@metamask/accounts-controller

  • CHANGED: BREAKING: Bump keyring-internal-api to ^2.0.0
  • CHANGED: BREAKING: Bump eth-snap-keyring to ^8.0.0

@metamask/chain-controller

  • CHANGED: BREAKING: Bump keyring-internal-api to ^2.0.0

@metamask/keyring-controller

  • CHANGED: BREAKING: Bump keyring-internal-api to ^2.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly requested review from a team as code owners January 13, 2025 14:29
@socket-security Socket Security
Copy link

socket-security bot commented Jan 13, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-snap-keyring@8.0.0 None +20 4.33 MB metamaskbot
npm/@metamask/keyring-internal-api@2.0.0 None +2 888 kB metamaskbot

View full report↗︎

@ccharly ccharly force-pushed the chore/update-keyring-account-scopes-versioning branch from 824a30f to 5d40964 Compare January 13, 2025 14:33
@ccharly ccharly changed the title chore: fix accounts-related packages versioning for new scopes feature chore: update accounts-related packages versioning for new scopes feature Jan 13, 2025
@ccharly ccharly merged commit a7ed53d into main Jan 13, 2025
120 checks passed
@ccharly ccharly deleted the chore/update-keyring-account-scopes-versioning branch January 13, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccharly @mirceanis @Prithpal-Sooriya @gantunesr