feat!: add scopes field to KeyringAccount
#5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
scopes field to KeyringAccount
0a46981 to
28a9753
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
2a41698 to
808b388
Compare
8 tasks
3fcac04 to
21d7074
Compare
21d7074 to
fd50073
Compare
fd50073 to
865cff8
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
scopes field to KeyringAccountscopes field to KeyringAccount
4c331dd to
6c3ef88
Compare
gantunesr
approved these changes
Jan 9, 2025
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
approved these changes
Jan 9, 2025
matthewwalsh0
approved these changes
Jan 9, 2025
sahar-fehri
approved these changes
Jan 9, 2025
mathieuartu
approved these changes
Jan 9, 2025
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
## Explanation Testing the new `scopes` field for `KeyringAccount` ## References - MetaMask/accounts#101 - MetaMask/metamask-extension#29195 ## Changelog ### `@metamask/accounts-controller` - **CHANGED**: Bump `keyring-api` to `^13.0.0` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` - **CHANGED**: **BREAKING:** Add new `scopes` field to `InternalAccount` - This new field wil automatically defaults to `eip155` (CAIP-2 chain ID namespace for EVM) for newly created EOA accounts (both Snap and "normal" accounts). ### `@metamask/assets-controllers` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` ### `@metamask/chain-controller` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` ### `@metamask/keyring-controller` - **CHANGED**: Bump `keyring-api` to `^13.0.0` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` - **CHANGED**: Await for `generateRandomMnemonic` keyring calls - Not all keyrings uses an `async` implementation for this method, but `await`ing should cover both (synchronous and asynchronous) cases. - This change is required since the bump of `@metamask/utils@^11.0.1` that changed the `generateRandomMnemonic` function signature for the `EthKeyring` interface (coming from `@metamask/keyring-internal-api`. ### `@metamask/profile-sync-controller` - **CHANGED**: Bump `keyring-api` to `^13.0.0` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
4 tasks
ccharly
added a commit
that referenced
this pull request
Jan 13, 2025
…eature (#5136) ## Explanation Some accounts packages were not properly versioned when introducing the new `scopes` feature. This has now been fixed and this PR bumps each accounts packages accordingly. ## References - #5066 - MetaMask/accounts#137 - MetaMask/accounts#133 ## Changelog ### `@metamask/accounts-controller` - **CHANGED**: **BREAKING:** Bump `keyring-internal-api` to `^2.0.0` - **CHANGED**: **BREAKING:** Bump `eth-snap-keyring` to `^8.0.0` ### `@metamask/chain-controller` - **CHANGED**: **BREAKING:** Bump `keyring-internal-api` to `^2.0.0` ### `@metamask/keyring-controller` - **CHANGED**: **BREAKING:** Bump `keyring-internal-api` to `^2.0.0` ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Testing the new
scopesfield forKeyringAccountReferences
scopesfield toKeyringAccountaccounts#101scopesfield toKeyringAccountmetamask-extension#29195Changelog
@metamask/accounts-controllerkeyring-apito^13.0.0keyring-internal-apito^1.1.0scopesfield toInternalAccounteip155(CAIP-2 chain ID namespace for EVM) for newly created EOA accounts (both Snap and "normal" accounts).@metamask/assets-controllerskeyring-internal-apito^1.1.0@metamask/chain-controllerkeyring-internal-apito^1.1.0@metamask/keyring-controllerkeyring-apito^13.0.0keyring-internal-apito^1.1.0generateRandomMnemonickeyring callsasyncimplementation for this method, butawaiting should cover both (synchronous and asynchronous) cases.@metamask/utils@^11.0.1that changed thegenerateRandomMnemonicfunction signature for theEthKeyringinterface (coming from@metamask/keyring-internal-api.@metamask/profile-sync-controllerkeyring-apito^13.0.0keyring-internal-apito^1.1.0Checklist