Issue 5239 simulated relationship behavior fixes #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @IllianiCBT , this is ready for review. I don't think I can add assignees, so a comment it is. Thanks! |
|
Perfect. I'm out of the office atm, but I'll take a butchers once I'm done. Welcome to the project! :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5240 +/- ##
============================================
- Coverage 10.51% 10.50% -0.01%
+ Complexity 6048 6042 -6
============================================
Files 957 957
Lines 134589 134616 +27
Branches 19541 19538 -3
============================================
- Hits 14152 14144 -8
- Misses 119083 119120 +37
+ Partials 1354 1352 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…nceive will roll for historic births
IllianiCBT
requested changes
Nov 24, 2024
MekHQ/src/mekhq/campaign/personnel/procreation/AbstractProcreation.java
Outdated
Show resolved
Hide resolved
…nceive will roll for historic births
…nceive will roll for historic births
…tps://github.com/psikomonkie/mekhq into issue-5239-simulated-relationship-behavior-fixes
(cherry picked from commit 1c2cbae)
Hey @IllianiCBT , I made the changes you requested. |
IllianiCBT
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulated Relationships allowed females to get pregnant and give birth in the same week, letting them have more kids than possible. Characters in simulated relationships with females were unable to procreate, and if they did their children wouldn't be saved. Children from simulated relationships will have a high school education if they're at least 16.
Solves issue #5239