Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behavior in simulated relationships #5239

Closed
7 tasks done
SirChaos1 opened this issue Nov 23, 2024 · 4 comments
Closed
7 tasks done

Odd behavior in simulated relationships #5239

SirChaos1 opened this issue Nov 23, 2024 · 4 comments
Labels
Personnel Personnel-related Issues

Comments

@SirChaos1
Copy link

Prerequisites and Pre-Issue Checklist

  • I'm reporting the issue to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • I've tested the issue against at least the latest MILESTONE version

  • I've asked on the MegaMek Discord about the error

  • I've reviewed the BattleTech rules and MekHQ documentation, and I've confirmed that something isn't working as intended.

  • I've searched the Github tracker and haven't found the issue listed

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

I´ve noticed some behavior in simulated reationships that is presumably not working as designed:

  1. Female characters may have a pair of children with their birth date several weeks to a month apart. I assume that those are pairs of twins, but that the simulated relationship mechanics determine the birth date separately for each twin, instead of using the same for both as real life and the in-campaign procreation system do.

  2. The "no longer trying to conceive" dice roll does not appear to firing during simulated relationships. At least, I cannot recall seeing a single female character who had at least one kid during the simulated relationship phase whose "trying to conceive" flag was set to "no", indicating that the dice roll after birth of her youngest child came up as "1". Older female characters who started out as trying to conceive tend to have a lot of children during the simulated relationship phase as a result (I see quite a few newly generated age 50+ female characters with 8-10 children in my campaign).

  3. When a male character gets married during the simulated relationship phase and a female dependant spouse is generated, is that spouse also going through conception rolls from the time of marriage to the start of the campaign, the way non-dependant female characters are? Because, while have seen a lot of male characters starting out married or divorced, I cannot recall any of those married to (or divorced from) a woman to have children.

  4. Children born during the simulated relationship phase, even if they are adults at campaign start, have Early Childhood education level.

Steps to Reproduce

The issues should be straightforward to reproduce by generating a considerable number of personnel with "simulate relationship history" turned on and studying the result; maybe set a high minimum age in the Bulk Hire Personnel dialogue to make sure there´s plenty of time for simulated relationships to happen.

Operating System *

Windows 10

Java Version *

Java 17

MekHQ Suite Version *

None

Custom MekHQ Version

0.50.01

Attach Files

No response

Final Checklist

  • I've checked to make sure that this issue has not already been filed
  • I'm reporting only one issue in this ticket for clarity and focus
@psikomonkie
Copy link
Collaborator

@SirChaos1 - I've submitted a PR with fixes for 1, 3, and 4.

I think 2 (The "no longer trying to conceive" dice roll does not appear to firing during simulated relationships.) is working as intended. Based on what I see in the campaign options, "No longer trying to conceive" is only rolled once, when a character is created. It is not re-rolled at any point.

@IllianiCBT
Copy link
Collaborator

Actually, there should be a chance to opt out of future conception rolled whenever a character has a child. It’s entirely possible that was missed out of the simulation. Same with marriages (after a divorce there should be a die rolled to see whether they opt out of future marriage)

@psikomonkie
Copy link
Collaborator

I see! Both divorce & background divorce have the reroll, but only the regular birth has the reroll. I've added it to birthHistoric, which is only used in the simulated relationships. Thanks!

@repligator repligator added the Personnel Personnel-related Issues label Nov 24, 2024
@IllianiCBT
Copy link
Collaborator

Closing as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues
Projects
None yet
Development

No branches or pull requests

4 participants