For #4855 - Annotate ATB Rules Spreadsheet #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotations added to each tab of ATB rules spreadsheet. Converted doc to latest Excel file format. I've tried to mark each workbook with what is implemented and not. Needs review by somebody who can see more of the code.
|
Tagging @IllianiCBT as the MekHQ guru, and @HammerGS as the First Data Lord for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4866 +/- ##
============================================
+ Coverage 10.30% 10.32% +0.01%
- Complexity 5871 5886 +15
============================================
Files 944 944
Lines 131394 131403 +9
Branches 19063 19064 +1
============================================
+ Hits 13545 13564 +19
+ Misses 116532 116528 -4
+ Partials 1317 1311 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations added to each tab of ATB rules spreadsheet. Converted doc to latest Excel file format. I've tried to mark each workbook with what is implemented and not. Needs review by somebody who can see more of the code.
I've not deleted the original file until folks confirm they're happy my notes in the doc are accurate.
File for ease of review:
Official AtB TT Rules 2.32 - Annotated.xlsx