Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Update AtB Excel to note it's lack of updates compared to the code #4855

Closed
5 tasks done
SuperStucco opened this issue Sep 18, 2024 · 4 comments
Closed
5 tasks done
Labels
Good First Issue A good issue to tackle for new MekHQ developers (RFE) Enhancement Requests for Enhancement, new features or implementations

Comments

@SuperStucco
Copy link

Prerequisites and Pre-Issue Checklist

  • I'm reporting the RFE to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • Does this conform with our Content Policy linked above?

  • I've searched the GitHub tracker and haven't found a similar feature request listed

RFE Details *

This is an improvement to an existing feature

Brief Description *

Implementation of the AtB/Against the Bot rules has been modified, improved upon, and otherwise changed over the years while the original Excel document has not changed. This leads to increasing numbers of questions about why MekHQ does this or that, while the document says otherwise.

It would help answer these questions right away if the AtB Excel document was modified to include some big, bold words (similar to the note for the Noble ruleset) that the contents are not being actively maintained, the current implementation may differ, and that the contents are retained for legacy purposes.

MekHQ Suite Version *

v.050.0

Attach Files

No response

Final Checklist

  • I've checked to make sure that this RFE has not already been filed
  • I am requesting implementation of only one relevant set of features in this ticket for clarity and focus
@SuperStucco SuperStucco added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Sep 18, 2024
@IllianiCBT
Copy link
Collaborator

I don't have easy access to excel, but if someone wants to do this and just send me the file I'll be happy to put in the PR so whomever doesn't have to set up a dev environment just for this

@IllianiCBT IllianiCBT added the Good First Issue A good issue to tackle for new MekHQ developers label Sep 18, 2024
@UlyssesSockdrawer
Copy link
Collaborator

Is there a list of what is no longer current in the doc? I can go in and update this tomorrow after some in-office meetings & PR it in.

@IllianiCBT
Copy link
Collaborator

There isn't a list, but anything covered by the new documentation (in either docs/personnel modules or docs/AtB and StratCon) are definitely not longer working as written.

I'll be honest, as I've gone through this stuff, finding an AtB system that works as written has proven rarer than not.

UlyssesSockdrawer added a commit to UlyssesSockdrawer/mekhq-Ulysses that referenced this issue Sep 20, 2024
Annotations added to each tab of ATB rules spreadsheet. Converted doc to latest Excel file format. I've tried to mark each workbook with what is implemented and not. Needs review by somebody who can see more of the code.
HammerGS added a commit that referenced this issue Sep 21, 2024
@UlyssesSockdrawer
Copy link
Collaborator

This can probably be closed now if folks are happy with my annotated version of the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue A good issue to tackle for new MekHQ developers (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

No branches or pull requests

4 participants