-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Campaign Presets & Addressed Relevant Name Change Issues #4817
Conversation
This PR factors in a number of pieces of feedback and oversights which came to light following the release of 50.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4817 +/- ##
============================================
+ Coverage 10.20% 10.76% +0.56%
- Complexity 5664 5668 +4
============================================
Files 948 948
Lines 132555 132553 -2
Branches 19048 19048
============================================
+ Hits 13529 14272 +743
+ Misses 117787 117041 -746
- Partials 1239 1240 +1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # MekHQ/mmconf/campaignPresets/Campaign Operations (StratCon).xml # MekHQ/mmconf/campaignPresets/Campaign Operations.xml # MekHQ/mmconf/campaignPresets/Complete Experience.xml # MekHQ/mmconf/campaignPresets/New Pilot Program.xml # MekHQ/mmconf/campaignPresets/Tabula Rasa.xml
Updated this PR to bring it in line with the recent naming overhaul and to fix a couple of minor issues that were preventing preset load. |
I also removed an unnecessary compatibility handler for Clan phenotype that was causing duplicate data to be displayed in campaign options. As we store this information as an Integer not a String, the handler wasn't necessary here, so it was simple enough to just remove. |
This PR factors in a number of pieces of feedback and oversights which came to light following the release of 50.0
Closes #4417 & #4764