Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Campaign Presets & Addressed Relevant Name Change Issues #4817

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Sep 12, 2024

This PR factors in a number of pieces of feedback and oversights which came to light following the release of 50.0

Closes #4417 & #4764

This PR factors in a number of pieces of feedback and oversights which came to light following the release of 50.0
@IllianiCBT IllianiCBT added Bug Campaign Options Relates to, or includes, campaign option changes labels Sep 12, 2024
@IllianiCBT IllianiCBT self-assigned this Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.76%. Comparing base (d433a26) to head (2dbc50b).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4817      +/-   ##
============================================
+ Coverage     10.20%   10.76%   +0.56%     
- Complexity     5664     5668       +4     
============================================
  Files           948      948              
  Lines        132555   132553       -2     
  Branches      19048    19048              
============================================
+ Hits          13529    14272     +743     
+ Misses       117787   117041     -746     
- Partials       1239     1240       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	MekHQ/mmconf/campaignPresets/Campaign Operations (StratCon).xml
#	MekHQ/mmconf/campaignPresets/Campaign Operations.xml
#	MekHQ/mmconf/campaignPresets/Complete Experience.xml
#	MekHQ/mmconf/campaignPresets/New Pilot Program.xml
#	MekHQ/mmconf/campaignPresets/Tabula Rasa.xml
@IllianiCBT
Copy link
Collaborator Author

Updated this PR to bring it in line with the recent naming overhaul and to fix a couple of minor issues that were preventing preset load.

@IllianiCBT
Copy link
Collaborator Author

I also removed an unnecessary compatibility handler for Clan phenotype that was causing duplicate data to be displayed in campaign options. As we store this information as an Integer not a String, the handler wasn't necessary here, so it was simple enough to just remove.

@IllianiCBT IllianiCBT merged commit 6e432bd into MegaMek:master Sep 13, 2024
3 checks passed
@IllianiCBT IllianiCBT changed the title Updated Campaign Presets Updated Campaign Presets & Addressed Relevant Copyright Name Change Issues Sep 13, 2024
@IllianiCBT IllianiCBT changed the title Updated Campaign Presets & Addressed Relevant Copyright Name Change Issues Updated Campaign Presets & Addressed Relevant Name Change Issues Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Campaign Options Relates to, or includes, campaign option changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oblique artilleryman SPA should have a pre requisite of at least regular in artillery?
2 participants