Non mechwarriors always get the natural aptitude piloting SPA

[ThomasMarik]

Environment

What version of MekHQ does your issue apply to? 0.50
What operating system are you using? Windows, Mac, or Linux? Windows
What java version are you using? 17

Description

When generating a company all non mechwarriors who are selected to get an SPA always gets assigned natural aptitude piloting. While nice that some people might have hidden talents it is very strange that it is always Natural aptitude piloting and not something specific to their jobs.

[IllianiCBT]

Based on the description this may be a return of a previously resolved issue caused by these SPAs not having prerequisites.

Another potential cause is that the affected personnel all qualify for the SPAs via Small Arms. Potentially, the SPA pool for affected personnel might be so small that this is the only SPA they qualify for.

Ultimately, this whole issue is caused by how we determine what random SPAs a character receives.

[IllianiCBT]

Just confirmed, Natural Aptitude SPAs lost their prerequisites again. So that's the cause.

[IllianiCBT]

Ok, I can confirm this was entirely due to incompetence on my part. It turns out I forgot to add the missing requirements for the Natural SPAs when I made the PR that was specifically meant to address that issue.

[Thom293]

I solved this partially with setting some other "natural" sounding spas to be in the same bucket with NAP and NAG. Stuff like small pilot (which is disabled in default I think) eagle eyes, some of the [condition] masters, and some others. And also gave them prerequisites. It makes NAP and NAG suitably rare.

[IllianiCBT]

Closing as resolved