Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max contract salvage percentage to campaign options #3821

Merged

Conversation

kuronekochomusuke
Copy link
Collaborator

  • add max contract salvage percentage to campaign options

image

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (3fc49e6) 10.63% compared to head (9e0afe8) 10.63%.
Report is 6 commits behind head on master.

Files Patch % Lines
MekHQ/src/mekhq/utilities/MHQXMLUtility.java 8.82% 62 Missing ⚠️
MekHQ/src/mekhq/gui/panes/CampaignOptionsPane.java 0.00% 17 Missing ⚠️
MekHQ/src/mekhq/campaign/CampaignOptions.java 42.85% 4 Missing ⚠️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3821   +/-   ##
=========================================
  Coverage     10.63%   10.63%           
- Complexity     5474     5475    +1     
=========================================
  Files           834      834           
  Lines        113836   113860   +24     
  Branches      17198    17199    +1     
=========================================
+ Hits          12106    12109    +3     
- Misses       100524   100545   +21     
  Partials       1206     1206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thom293
Copy link
Contributor

Thom293 commented Jan 27, 2024

Ohmygodthankyousomuch.

@HammerGS HammerGS merged commit 186b5bc into MegaMek:master Feb 4, 2024
6 checks passed
HammerGS added a commit that referenced this pull request Feb 4, 2024
+ PR #3821: Add max contract salvage percentage to campaign options

+ Fix #3763: Reversing quality names in unit set quality GM menu

+ FIx #3194: Awarding non-stackable medals to multiple people
@kuronekochomusuke kuronekochomusuke deleted the contractMaxSalvagePercentage branch April 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants