Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Awarding non-stackable medals to multiple people should award to those that do not already have the medal #3194

Closed
mjbroekman opened this issue Mar 28, 2022 · 0 comments · Fixed by #3822
Closed

RFE: Awarding non-stackable medals to multiple people should award to those that do not already have the medal #3194

mjbroekman opened this issue Mar 28, 2022 · 0 comments · Fixed by #3822
Labels
Awards Personnel Personnel-related Issues (RFE) Enhancement Requests for Enhancement, new features or implementations

Comments

@mjbroekman
Copy link

Environment

MekHQ 0.49.7

Description

When you are awarding non-stackable medals (such as Marksmanship, Galactic War on Pirating, etc) to a unit, the medal does not show up in the list of awards if anyone in the selection has already received the medal. This means, if you have fought pirates, then had multiple personnel changes, and then fought pirates again, you need to go through and check each person's log to find the ones that have NOT received the medal so that you can award them the medal.

###Request for Enhancement
If you select a group of people in order to award them a medal, show all the medals. If the selected medal is non-stackable, only award it to those personnel that do NOT already have it.
@Windchild292 Windchild292 added (RFE) Enhancement Requests for Enhancement, new features or implementations Awards Personnel Personnel-related Issues labels Apr 11, 2022
@mjbroekman mjbroekman mentioned this issue Jul 13, 2022
Open
jackreichelt added a commit to jackreichelt/mekhq that referenced this issue Jan 29, 2024
@jackreichelt
MegaMek#3194 Showing all awards if multiple personnel selected but no…
d96e9a5 
…t re-awarding non-stackable awards
@jackreichelt jackreichelt mentioned this issue Jan 29, 2024
Merged
HammerGS added a commit that referenced this issue Feb 4, 2024
@HammerGS
Merge pull request #3822 from jackreichelt/3194-awarding-non-stackabl…
3aa366f 
…e-medals

#3194 Awarding non-stackable medals to multiple people
HammerGS added a commit that referenced this issue Feb 4, 2024
@HammerGS
Merging PR's
880d3f4 
+ PR #3821: Add max contract salvage percentage to campaign options

+ Fix #3763: Reversing quality names in unit set quality GM menu

+ FIx #3194: Awarding non-stackable medals to multiple people
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awards Personnel Personnel-related Issues (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3194 Awarding non-stackable medals to multiple people jackreichelt/mekhq
2 participants
@mjbroekman @Windchild292