Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no newline when debug msg over DEBUG_BUF_SIZE #7607

Merged
merged 8 commits into from
May 17, 2023
Merged

Fix: no newline when debug msg over DEBUG_BUF_SIZE #7607

merged 8 commits into from
May 17, 2023

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented May 16, 2023 •
edited by davidhorstmann-arm
Loading

Description

Rebase of #6511 with a fix for the static assert issue.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

valord577 and others added 8 commits May 16, 2023 16:42
@valord577 @daverodgman
Fix: no newline when debug msg over DEBUG_BUF_SIZE
25418ac 
Signed-off-by: valord577 <valord577@gmail.com>
@daverodgman
Update library/debug.c
9ecf5f9 
Fix trailing white-space

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@valord577 @daverodgman
send debug msg if contains '\n'
24da0cd 
Signed-off-by: valord577 <valord577@gmail.com>
@valord577 @daverodgman
make code readable and change var name
536893c 
Signed-off-by: valord577 <valord577@gmail.com>
@valord577 @daverodgman
code style
176e927 
Signed-off-by: valord577 <valord577@gmail.com>
@valord577 @daverodgman
simplify code
5bfcd1c 
Signed-off-by: valord577 <valord577@gmail.com>
@daverodgman
Document minimum size for DEBUG_BUF_SIZE
ed59ea7 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Make use of MBEDTLS_STATIC_ASSERT
8508e50 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
This was referenced May 16, 2023
Closed
Merged
@daverodgman daverodgman added bug needs-review Every commit must be reviewed by at least two team members, needs-backports Backports are missing or are pending review and approval. component-platform Portability layer and build scripts needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels May 16, 2023
davidhorstmann-arm
davidhorstmann-arm approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm self-requested a review May 17, 2023 15:16
tom-daubney-arm
tom-daubney-arm approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests needs-backports Backports are missing or are pending review and approval. labels May 17, 2023
@daverodgman daverodgman merged commit e4cbab6 into Mbed-TLS:development May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-platform Portability layer and build scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daverodgman @davidhorstmann-arm @tom-daubney-arm @valord577