Fix: no newline when debug msg over DEBUG_BUF_SIZE #6511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: valord577 <valord577@gmail.com>
daverodgman
reviewed
Oct 31, 2022
Fix trailing white-space Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
Signed-off-by: valord577 <valord577@gmail.com>
Signed-off-by: valord577 <valord577@gmail.com>
Signed-off-by: valord577 <valord577@gmail.com>
Signed-off-by: valord577 <valord577@gmail.com>
daverodgman
previously approved these changes
Feb 15, 2023
There was a problem hiding this comment.
LGTM. I would ideally like to see a comment next to line 33 specifying that DEBUG_BUF_SIZE must be > 2 rather than just rely on the static assert elsewhere, but it's not a blocker.
Edit: actually, rather than iterate the PR I've just added a comment. If @tom-cosgrove-arm approves we can merge.
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
803658e
daverodgman
approved these changes
Feb 15, 2023
|
:p - Please Use Squash Merging! |
|
Does this need a backport? |
gilles-peskine-arm
requested changes
Feb 21, 2023
| @@ -69,6 +70,10 @@ void mbedtls_debug_print_msg(const mbedtls_ssl_context *ssl, int level, | |||
| char str[DEBUG_BUF_SIZE]; | |||
| int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; | |||
|
|
|||
| #if defined(static_assert) | |||
There was a problem hiding this comment.
That's never going to trigger without #include <assert.h>.
There was a problem hiding this comment.
Bah, good spot - thanks
3 tasks
|
Rebased with a fix for the static assert issue in #7607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: valord577 valord577@gmail.com
Description
Fix: no newline when debug msg over DEBUG_BUF_SIZE
Status
READY/IN
!!! Please Use Squash Merging