Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix typos prior to release #6718

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Backport 2.28: Fix typos prior to release #6718

merged 3 commits into from
Dec 6, 2022

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Dec 4, 2022 •
edited by daverodgman
Loading

Gatekeeper checklist

@tom-cosgrove-arm
Fix typos prior to release
49f99bc 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Dec 4, 2022
Merged
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm changed the title Fix typos prior to release Backport 2.28: Fix typos prior to release Dec 4, 2022
@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon needs-ci Needs to pass CI tests labels Dec 4, 2022
@tom-cosgrove-arm
Don't change typos in debug messages used by ssl-opt.sh
c1b9842 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
davidhorstmann-arm
davidhorstmann-arm previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tom-cosgrove-arm
Fix another typo where 'PSK' was 'PKS'
e87c335 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@daverodgman daverodgman added single-reviewer This PR qualifies for having only one reviewer approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 5, 2022
@tom-cosgrove-arm tom-cosgrove-arm removed the needs-ci Needs to pass CI tests label Dec 6, 2022
@tom-cosgrove-arm
Copy link
Contributor Author

CI passed

@daverodgman daverodgman merged commit 0f1bdea into Mbed-TLS:mbedtls-2.28 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daverodgman daverodgman daverodgman approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-cosgrove-arm @daverodgman @davidhorstmann-arm