Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos prior to release #6717

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Fix typos prior to release #6717

merged 3 commits into from
Dec 6, 2022

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Dec 4, 2022 •
edited by daverodgman
Loading

Gatekeeper checklist

@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Dec 4, 2022
Merged
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm added needs-backports Backports are missing or are pending review and approval. needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon labels Dec 4, 2022
@tom-cosgrove-arm
Fix typos prior to release
1797b05 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@gilles-peskine-arm
Copy link
Contributor

This conflicts with #6689. Please don't touch changelog entries here or rebase on top of #6689. Likewise with backports.

@tom-cosgrove-arm tom-cosgrove-arm removed the needs-ci Needs to pass CI tests label Dec 5, 2022
@tom-cosgrove-arm
Copy link
Contributor Author

Likewise with backports

Not sure what "likewise" means here. The backport #6718 doesn't touch any changelog entries. Or does "likewise" here mean "don't backport"? I thought it would make more sense to have typos fixed in both branches so that future backport PRs apply cleanly.

Can you clarify?

@tom-cosgrove-arm
ChangeLog entry is fixed in a different PR
416b48c 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@tom-cosgrove-arm tom-cosgrove-arm added the needs-ci Needs to pass CI tests label Dec 5, 2022
davidhorstmann-arm
davidhorstmann-arm previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm
Fix another typo where 'PSK' was 'PKS'
ed4f59e 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@daverodgman daverodgman added size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer and removed needs-reviewer This PR needs someone to pick it up for review labels Dec 5, 2022
@daverodgman daverodgman added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Dec 5, 2022
@tom-cosgrove-arm tom-cosgrove-arm removed the needs-ci Needs to pass CI tests label Dec 6, 2022
@tom-cosgrove-arm
Copy link
Contributor Author

CI is green

@daverodgman daverodgman merged commit 92011ee into Mbed-TLS:development Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wernerlewis wernerlewis wernerlewis approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval. priority-high High priority - will be reviewed soon single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tom-cosgrove-arm @gilles-peskine-arm @wernerlewis @davidhorstmann-arm @daverodgman