bugfix STATIC_ITEM_N not working as intended #19360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix 2.0.x
sorry im not a programer but i did my best to get 2 seperated controls for extra visual indiaction from the LEDS by keeping the Printer Events on the main channel .
… into bugfix-2.0.x
Originally labeled as DUET_SMART_EFFECTOR but this is incorrect as MarlinCore looks for SMART_EFFECTOR and not DUET_SMART_EFFECTOR
… into bugfix-2.0.x
for some reason NEOPIXEL_SEPERATE ended up missing in config
makes sure there is a need
added a check for the neopixel2 pin when neopixel separate is enabled
still problems with #elif ENABLED(NEOPIXEL2_SEPARATE) && !(NEOPIXEL2_TYPE && PIN_EXISTS(NEOPIXEL2) && NEOPIXEL2_PIXELS > 0) Error is a;ways flagged
I believe the N is supposed to be there
#define STATIC_ITEM_N_P(PLABEL, N, V...) do{ \
if (_menuLineNr == _thisItemNr) { \
MenuItemBase::init(N); \
STATIC_ITEM_INNER_P(PLABEL, ##V); \
} \
NEXT_ITEM(); \
}while(0)
|
You are 21 commits behind. You should be careful to only reference the most up to date code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
im confused about the removal of the N in the
#define STATIC_ITEM_N(LABEL, V...) STATIC_ITEM_N_P(GET_TEXT(LABEL), ##V)when #19303 was merged because its looking for N, right?without N
STATIC_ITEM_Nact the same asSTATIC_ITEMRelated Issues