Bugfix #19280 lcd LED menu showing channel 3 for both channels when neopixel2 separate is enabled #19303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix 2.0.x
sorry im not a programer but i did my best to get 2 seperated controls for extra visual indiaction from the LEDS by keeping the Printer Events on the main channel .
… into bugfix-2.0.x
Originally labeled as DUET_SMART_EFFECTOR but this is incorrect as MarlinCore looks for SMART_EFFECTOR and not DUET_SMART_EFFECTOR
… into bugfix-2.0.x
for some reason NEOPIXEL_SEPERATE ended up missing in config
still problems with #elif ENABLED(NEOPIXEL2_SEPARATE) && !(NEOPIXEL2_TYPE && PIN_EXISTS(NEOPIXEL2) && NEOPIXEL2_PIXELS > 0) Error is a;ways flagged
|
its the only menu to use |
|
that was a whoopsy sorry about the closed and reopen i really dont know how i managed that |
Bacon-Fixation
commented
Sep 12, 2020
| #define STATIC_ITEM(LABEL, V...) STATIC_ITEM_P(GET_TEXT(LABEL), ##V) | ||
| #define STATIC_ITEM_N(LABEL, N, V...) STATIC_ITEM_N_P(GET_TEXT(LABEL), N, ##V) | ||
| #define STATIC_ITEM(LABEL, V...) STATIC_ITEM_P(GET_TEXT(LABEL), ##V) | ||
| #define STATIC_ITEM_N(LABEL, V...) STATIC_ITEM_N_P(GET_TEXT(LABEL), ##V) |
There was a problem hiding this comment.
im confused about the removal of the N in the #define STATIC_ITEM_N(LABEL, V...) STATIC_ITEM_N_P(GET_TEXT(LABEL), ##V) because its looking for it, right?
#define STATIC_ITEM_N_P(PLABEL, N, V...) do{ \
if (_menuLineNr == _thisItemNr) { \
MenuItemBase::init(N); \
STATIC_ITEM_INNER_P(PLABEL, ##V); \
} \
NEXT_ITEM(); \
}while(0)
This was referenced Sep 12, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a display error that happens when you go to the custom LED controls where both channels say "Channel 3"
noticed the
STATIC_ITEM_Nmacro was missing somethingin lcd_item.h
#define STATIC_ITEM_N(LABEL, N, V...) STATIC_ITEM_N_P(GET_TEXT(LABEL), ##V)the N was missing on the other side and was displaying a 3 that was possibly from theSS_DEFAULT|SS_INVERTinstead of the number rather than the number value inSTATIC_ITEM_N(MSG_LED_CHANNEL_N, 1, SS_DEFAULT|SS_INVERT);in menu_led.h.i could change it to
STATIC_ITEM_N(MSG_LED_CHANNEL_N, 9, SS_DEFAULT|SS_INVERT);and still have a 3 on the lcd.Related Issues
#19280 showing channel 3 on both labels on the lcd screen