Site.js: remove site generation profiling #748
Conversation
src/Site.js
Outdated
| .finally(() => { | ||
| const endTime = new Date(); | ||
| const totalBuildTime = endTime - startTime; | ||
| logger.debug(`Total generation time: ${totalBuildTime}ms`); |
There was a problem hiding this comment.
Let's:
- rename this variable to
totalGenerationTime. - use seconds, to be consistent with the existing
totalBuildTime. - remove the
profileexport in logger.js.
There was a problem hiding this comment.
Should we downgrade the profile logging in logger.js#profile() instead, like so:
logger.profile('test', { level: 'debug' });Otherwise, if we are not planning to do any extensive profiling in the future, there's not really a reason for this portion of the code to stay.
There was a problem hiding this comment.
It seems necessary to upgrade the version of logger (winston) from 2 to 3 in order to execute that code. logger.profile('test', { level: 'debug' });
https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md
There was a problem hiding this comment.
Let's just get rid of this part of the code then.
|
Your first post and PR title will need to be updated, the PR title can be |
|
Title updated |
|
Thank you for your reviews. 🙇 |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes #738
What changes did you make? (Give an overview)
Get rid of the logger.profile()
use Date() and show generate time on debug level