-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing space in log output #738
Comments
Hello. Is this output necessary? Lines 506 to 536 in ba77643
|
Good question. The two numbers seem to differ slightly though. Let's wait to hear from a senior developer. |
Yes, this line popped up because we now print everything to the console since #721 came. Previously it was hidden inside the log, and never printed on the console. The duration given by the profiler is always printed regardless of whether the site builds successfully or not (which is why it takes a slightly longer time before printing, compared to the one that prints straight away immediately after the generation is complete). I don't think it is useful to print the duration when the site fails to build, so it should not be shown to the authors. Instead, we should explore downgrading the log levels for profiler messages, so that it doesn't show up on "info:" level. |
Current:

A space is missing? This can be phrased in a more readable way? e.g.,
1234 ms
The text was updated successfully, but these errors were encountered: