-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize variable syntax #743
Conversation
I think it should be removed eventually, don't see the value in the old syntax since it is hard to differentiate it from actual We will deprecate this feature first, then remove it by the next big release as per standard practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the updated logic, and also skimmed around the documentation a bit to see whether all necessary replacements are done, seems generally fine to me 👍.
5b88fe8
to
d099520
Compare
Rebased to solve merge conflict |
Proposed commit message:
|
We use <span> to declare variables in include and global variables. <span> variables are difficult to differentiate from actual <span> tag uses. Furthermore, in places where this differentiation is important (e.g. pages where <span>s are extremely common), we are forced to use <variable> tags, rather than <span> tags. This results in two different (and confusing) ways of declaring variables. Let's standardize all variable declaration to use <variable> instead of <span>. The processing of <span> variables are currently left intact, but they are deprecated and should be removed in a subsequent release.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Other, please explain: Refactoring
Fixes #710
What is the rationale for this request?
Two different variable syntaxes are used,
<span id=...>
for include and global variables,<variable name=...>
for page variables. For standardization we should only use one.What changes did you make? (Give an overview)
Change all variables to use
<variable name=...>
syntax.Testing instructions:
I left compatibility for
<span id=...>
- prevents old sites from breaking. Should it be removed?Can confirm something like this works: