Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the syntax for defining variables #710

Closed
damithc opened this issue Feb 18, 2019 · 5 comments · Fixed by #743
Closed

Standardize the syntax for defining variables #710

damithc opened this issue Feb 18, 2019 · 5 comments · Fixed by #743

Comments

@damithc
Copy link
Contributor

damithc commented Feb 18, 2019

Current:
Global variables use <span id="foo"> syntax
Page variables use <variable name="foo"> syntax

Should we allow <variable name="foo"> syntax to be used for global variables too?

@damithc damithc added p.Low f-Variables s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding a-Syntax labels Feb 18, 2019
@yamgent
Copy link
Member

yamgent commented Feb 19, 2019

Should we allow <variable name="foo"> syntax to be used for global variables too?

Sure, don't see any disadvantages in that. Should we deprecate the <span> syntax as well?

@damithc
Copy link
Contributor Author

damithc commented Feb 19, 2019

Sure, don't see any disadvantages in that. Should we deprecate the <span> syntax as well?

Yes, we can deprecate it.

@yamgent yamgent removed the s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding label Feb 19, 2019
@jamos-tay
Copy link
Contributor

Sure, how about include variables?

<include src...>
  <span id="x">var</span>
</include>

@damithc
Copy link
Contributor Author

damithc commented Feb 19, 2019

Sure, how about include variables?

Good point. Do the same there as well? What do you guys think?

@yamgent
Copy link
Member

yamgent commented Feb 21, 2019

Good point. Do the same there as well? What do you guys think?

Yes let's do it all in one shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants