Autoscroll after the whole page is loaded #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf6ca8d to
85c9ba0
Compare
yamgent
reviewed
Jul 24, 2018
asset/js/setup.js
Outdated
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| Vue.use(VueStrap); | |||
|
|
|||
| function scrollToHeading() { | |||
There was a problem hiding this comment.
You need to call this method in setup() as well.
I am not sure whether setup() is relevant anymore (siteData.json is always generated nowadays afaik?), but for consistency sake you should still add this call.
There was a problem hiding this comment.
Also, a better name for the method can be scrollToUrlAnchorHeading().
yamgent
approved these changes
Jul 24, 2018
24cca0c to
1d1edc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [ ] Documentation update
• [X] Bug fix
• [ ] New feature
• [ ] Enhancement to an existing feature
• [ ] Other, please explain:
Fixes #310
What is the rationale for this request?
when jumping to specific headings in other pages or subsites, content is not loaded before the scrolling.
Which makes it scrolling to the wrong place.
What changes did you make? (Give an overview)
scrolling after the page is loaded(use Vuejs
mountedhook)Testing instructions:
markbind serve docsadvanced tips and trickslink is scrolling to the correct place