Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase success rate of auto-scroll-to-target-subheading of search results #310

Closed
damithc opened this issue Jul 7, 2018 · 2 comments · Fixed by #364
Closed

Increase success rate of auto-scroll-to-target-subheading of search results #310

damithc opened this issue Jul 7, 2018 · 2 comments · Fixed by #364
Labels
f-Search p.High To be done in the next few releases

Comments

@damithc
Copy link
Contributor

damithc commented Jul 7, 2018

v1.8.4

Steps:

Expected: Page auto-scrolls to the intended sub-heading
Actual: Most times the page scrolls to the wrong location of the page

I suspect there is a race between loading content and scrolling.

@nusjzx
Copy link
Contributor

nusjzx commented Jul 12, 2018

The problem is not caused by race between loading content and scrolling. I've tried scrolling after page loaded, it still can not jump to the heading.

@yamgent
Copy link
Member

yamgent commented Jul 12, 2018

As discussed, this is not just a problem specific to search only. It happens even when you try to load through a direct link to a sub-heading:

https://markbind.github.io/markbind/userGuide/components.html#advanced-tips-and-tricks

We need to figure out how to execute code after Vue finishes loading everything (can try document.ready, or Vue.mounted event hook).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f-Search p.High To be done in the next few releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants