-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional absolute char indexing for highlighting #2584
Open
AgentHagu
wants to merge
17
commits into
MarkBind:master
Choose a base branch
from
AgentHagu:leading-whitespace-highlighting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−28
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e4f0e2b
Update highlighter functionality to support new regex
AgentHagu 78c8e84
Add new test cases for highlighter
AgentHagu 46901a3
Update documentation for computeCharBounds
AgentHagu f679edb
Fix issue regarding failing test cases
AgentHagu fe14d75
Update symbol and position
AgentHagu 7cb451b
Update documentation to follow idea of absolute char indexing
AgentHagu 2245743
Refactor code to improve readability
AgentHagu ff20a24
Add default tab conversion
AgentHagu 23f9830
Update User Guide to reflect new behavior
AgentHagu 7f3d200
Merge branch 'master' into leading-whitespace-highlighting
lhw-1 2cff619
Fix issues with tab conversion
AgentHagu 8c9849a
Fix bug with failing test case
AgentHagu 35b674c
Merge branch 'master' into leading-whitespace-highlighting
AgentHagu 3ed3d84
Update user guide to better reflect tab conversion behavior
AgentHagu 841f9c4
Merge branch 'master' into leading-whitespace-highlighting
lhw-1 3cef17f
Merge branch 'master' into leading-whitespace-highlighting
lhw-1 876b010
Merge branch 'master' into leading-whitespace-highlighting
lhw-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix issue regarding failing test cases
groups.pop() was called without considering the number of capturing groups within. This caused some issues with the end bound of word matching being popped and removed from the array.
- Loading branch information
commit f679edbf0271fb0d37eedb096a26a4b46c2c1deb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.