Add optional leading whitespace highlighting #2584
Open
+52
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
This PR closes #2573. In summary, it allows users to now optionally highlight leading whitespace, giving them more options when using MarkBind.
Users can now add an optional
+
after their highlight index specifier to indicate that the index should be inclusive of leading whitespace. For example, previously1[:4]
would highlight theabcd
inabcd
. But now, by using1[:4]+
, MarkBind will highlightab
inabcd
(i.e. it will also highlight the first 2 spaces in the string).Anything you'd like to highlight/discuss:
nil
Testing instructions:
A test similar to the example brought up in #2573 can be used to test the new functionality. For example:
abcd
should be highlighted, i.e. exclusive of the 2 whitespaces in the beginning.Now,
ab
should be highlighted, since the "+" symbol was added, so leading whitespaces are included in the bounds calculation.Proposed commit message: (wrap lines at 72 characters)
Add optional leading whitespace highlighting
Currently, there is no way to include highlighting of leading
whitespace when using the
highlight-lines
attribute. Providing suchan option may be beneficial to users, giving them more freedom
when using MarkBind.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):